Skip to content

Commit

Permalink
Move full facade assemblies into src/libraries/shims (#89184)
Browse files Browse the repository at this point in the history
* Move full facade assemblies into src/libraries/shims

Fixes #78978

1. Move all full facade assemblies (which only contain type forwards)
   into src/libraries/shims.
2. Merge assemblies (ref+src) which typeforward to the same
   destination.
3. They inherently now don't produce a documentation file anymore (as
   shims only contain type forwards).

This minimizes the build graph (makes the libs build faster) and moves
the focus away from full facade assemblies that need to be kept for
compat reasons.

* Trigger CI for all legs

* Remove obsolete slns and undo CI change

* PR feedback from Eric

* Change System.ValueTuple type fowrard dest

* Collapse ref and src shims further

As discussed with Eric offline, typeforwarding to System.Runtime and
System.Xml.ReaderWriter makes it possible to collapse the following
ref and src projects into just src:

System.AppContext
System.Buffers
System.Diagnostics.Debug
System.Diagnostics.Tools
System.Globalization
System.Globalization.Calendars
System.IO.UnmanagedMemoryStream
System.Reflection
System.Resources.ResourceManager
System.Runtime.CompilerServices.Unsafe
System.Runtime.Extensions
System.Security.Principal
System.Text.Encoding
System.Threading.Timer
System.Xml.XmlDocument

The destination then handles the type fowarding to the private assembly
implementation.
  • Loading branch information
ViktorHofer committed Jul 21, 2023
1 parent 7531c50 commit a864ec7
Show file tree
Hide file tree
Showing 234 changed files with 415 additions and 8,993 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@
<Compile Include="System\Security\AccessControl\RegistrySecurity.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Buffers" />
<Reference Include="System.Collections" />
<Reference Include="System.Memory" />
<Reference Include="System.Runtime" />
Expand Down
6 changes: 0 additions & 6 deletions src/libraries/System.AppContext/Directory.Build.props

This file was deleted.

287 changes: 0 additions & 287 deletions src/libraries/System.AppContext/System.AppContext.sln

This file was deleted.

This file was deleted.

11 changes: 0 additions & 11 deletions src/libraries/System.AppContext/ref/System.AppContext.csproj

This file was deleted.

9 changes: 0 additions & 9 deletions src/libraries/System.AppContext/src/System.AppContext.csproj

This file was deleted.

287 changes: 0 additions & 287 deletions src/libraries/System.Buffers/System.Buffers.sln

This file was deleted.

7 changes: 0 additions & 7 deletions src/libraries/System.Buffers/ref/System.Buffers.Forwards.cs

This file was deleted.

9 changes: 0 additions & 9 deletions src/libraries/System.Buffers/ref/System.Buffers.csproj

This file was deleted.

11 changes: 0 additions & 11 deletions src/libraries/System.Buffers/src/System.Buffers.csproj

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

6 changes: 0 additions & 6 deletions src/libraries/System.Diagnostics.Debug/Directory.Build.props

This file was deleted.

Loading

0 comments on commit a864ec7

Please sign in to comment.