Bump requirement for QUIC async cert validation to MsQuic 2.4 (#106251)

* Bump requirement for async cert validation to 2.4 * Update MsQuicApi.cs
dotnet · Aug 13, 2024 · b080dc2 · b080dc2
1 parent 9f8b9bf
commit b080dc2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs b/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs
@@ -62,7 +62,7 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)
     internal static string? NotSupportedReason { get; }
 
     // workaround for https://github.com/microsoft/msquic/issues/4132
-    internal static bool SupportsAsyncCertValidation => Version >= new Version(2, 3, 5);
+    internal static bool SupportsAsyncCertValidation => Version >= new Version(2, 4);
 
     internal static bool UsesSChannelBackend { get; }
 

diff --git a/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs b/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
@@ -52,7 +52,6 @@ public class MsQuicTests : QuicTestBase, IClassFixture<CertificateSetup>
     {
         private static byte[] s_data = "Hello world!"u8.ToArray();
         readonly CertificateSetup _certificates;
-        static bool DoesNotSupportAsyncCertValidation => QuicTestCollection.MsQuicVersion < new Version(2, 4);
 
         public MsQuicTests(ITestOutputHelper output, CertificateSetup setup) : base(output)
         {
@@ -354,7 +353,6 @@ public async Task UntrustedClientCertificateFails()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/99074", typeof(MsQuicTests), nameof(DoesNotSupportAsyncCertValidation))]
         public async Task CertificateCallbackThrowPropagates()
         {
             using CancellationTokenSource cts = new CancellationTokenSource(PassingTestTimeout);