Skip to content

Commit

Permalink
Keep CLSCompliantAttribute in sync for src <-> ref (#66075)
Browse files Browse the repository at this point in the history
ApiCompat actually ran validation for that attribute until the check was
disabled with a675e1c.

Enable it again and only disable it for baseline api compat validation,
which is performed in ApiCompat.proj.
  • Loading branch information
ViktorHofer committed Mar 2, 2022
1 parent 58b8de9 commit b61687b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1 deletion.
1 change: 0 additions & 1 deletion eng/ApiCompatExcludeAttributes.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
T:System.CLSCompliantAttribute
T:System.Diagnostics.CodeAnalysis.MemberNotNullAttribute
T:System.Diagnostics.DebuggerGuidedStepThroughAttribute
T:System.Runtime.CompilerServices.EagerStaticClassConstructionAttribute
Original file line number Diff line number Diff line change
Expand Up @@ -1438,6 +1438,7 @@ public partial interface IConnectionPointContainer
void EnumConnectionPoints(out System.Runtime.InteropServices.ComTypes.IEnumConnectionPoints ppEnum);
void FindConnectionPoint(ref System.Guid riid, out System.Runtime.InteropServices.ComTypes.IConnectionPoint? ppCP);
}
[System.CLSCompliantAttribute(false)]
[System.Runtime.InteropServices.InterfaceTypeAttribute(System.Runtime.InteropServices.ComInterfaceType.InterfaceIsIUnknown)]
public partial interface IDataObject
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// These attributes shouldn't be checked against baseline reference assemblies

T:System.CLSCompliantAttribute
T:System.ComponentModel.EditorBrowsableAttribute
T:System.ObsoleteAttribute

0 comments on commit b61687b

Please sign in to comment.