-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Addressing Simon's PR feedback, msbuild project fixes for x86
Based on Simon's suggestion I moved the PDB / PerfMap-specific code to a new file SymbolFileBuilder as I concur that its squatting in the MapFileBuilder was somewhat hacky. Both classes use a new helper class ObjectInfoBuilder that collects the information common to both - I was reluctant to make it a base class of the *FileBuilder's as we'd have to collect all the elements twice. Thanks Tomas
- Loading branch information
Showing
10 changed files
with
374 additions
and
267 deletions.
There are no files selected for viewing
6 changes: 3 additions & 3 deletions
6
src/coreclr/tools/aot/ILCompiler.Diagnostics/ILCompiler.Diagnostics.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.