Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Link>...</Link> vs. Link="..." for Common files #1266

Closed
jkotas opened this issue Jan 3, 2020 · 3 comments · Fixed by #35436
Closed

<Link>...</Link> vs. Link="..." for Common files #1266

jkotas opened this issue Jan 3, 2020 · 3 comments · Fixed by #35436
Labels
area-Infrastructure-libraries good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@jkotas
Copy link
Member

jkotas commented Jan 3, 2020

Most libraries .csproj projects use <Link>...</Link> to link files from Common. There are a few that use Link="...". We should unify on one style.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Meta untriaged New issue has not been triaged by the area owner labels Jan 3, 2020
@jkotas jkotas mentioned this issue Jan 3, 2020
Merged
@jkotas
Copy link
Member Author

jkotas commented Jan 3, 2020

See #1247 (comment) for discussion of pros and cons of each option.

@jkotas jkotas removed the area-Meta label Jan 3, 2020
@danmoseley
Copy link
Member

It would be nice if there was a heuristic (it has had this behavior since the C# project system was created in VS2002)
dotnet/project-system#5765

@jkotas jkotas mentioned this issue Feb 15, 2020
Closed
@ViktorHofer
Copy link
Member

I prefer the attribute syntax over the element one here. We usually wrap additional attributes into multiple lines, which should help readability, e.g.: https://github.com/dotnet/runtime/blob/master/src/libraries/pretest.proj#L43-L48.

@ViktorHofer ViktorHofer added help wanted [up-for-grabs] Good issue for external contributors and removed untriaged New issue has not been triaged by the area owner labels Apr 17, 2020
@ViktorHofer ViktorHofer added this to the Future milestone Apr 17, 2020
@ViktorHofer ViktorHofer added the good first issue Issue should be easy to implement, good for first-time contributors label Apr 17, 2020
marcusturewicz added a commit to marcusturewicz/runtime that referenced this issue Apr 25, 2020
@marcusturewicz
Use attribute Link syntax for Common files
120d9cb 
Fixes dotnet#1266
@marcusturewicz marcusturewicz mentioned this issue Apr 25, 2020
Merged
@ManickaP ManickaP mentioned this issue Nov 26, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-libraries good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Use attribute Link syntax for Common files marcusturewicz/runtime
4 participants
@danmoseley @jkotas @ViktorHofer @Dotnet-GitSync-Bot