API Proposal: Expose Host.ConfigureDefaults

[davidfowl]

This would allow callers to provide the IHostBuilder instance without having to copy all the logic to setup defaults.

[analogrelay]

Do you have more specific details on the proposal? This is pretty low on info/details.

[analogrelay]

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. If it is closed, feel free to comment when you are able to provide the additional information and we will re-investigate.

See our Issue Management Policies for more information.

[davidfowl]

I had to copy the defaults because I wanted to use a different IHostBuilder implementation https://github.com/davidfowl/FeatherHttp/blob/ee5e2a8a701b73b1e57c5d4df5672fda63366779/src/FeatherHttp/WebApplication.cs#L221.

The request is simple, I’d rather not copy this logic 😬

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this issue. Please help me learn by adding exactly one area label.

[maryamariyan]

API Proposal Summary:

The ask is to move the IHostBuilder instantiation below out of the new API, so other callers can provide their own IHostBuilder to CreateDefaultBuilder

runtime/src/libraries/Microsoft.Extensions.Hosting/src/Host.cs

Line 58 in f7e0069

var builder = new HostBuilder();

namespace Microsoft.Extensions.Hosting
{
    public static partial class Host
    {
        public static Microsoft.Extensions.Hosting.IHostBuilder CreateDefaultBuilder() { throw null; }
        public static Microsoft.Extensions.Hosting.IHostBuilder CreateDefaultBuilder(string[] args) { throw null; }
+       public static Microsoft.Extensions.Hosting.IHostBuilder CreateDefaultBuilder(IHostBuilder builder, string[] args) { throw null; }
    }
}

[terrajobst]

Video

• Let's not name it CreateDefaultBuilder() because it doesn't actually create a new builder, it just applies the defaults.
• Let's make an extension method so that the usage looks less noisy
• That means we should move it to HostingHostBuilderExtensions instead

namespace Microsoft.Extensions.Hosting
{
    public static partial class HostingHostBuilderExtensions
    {
        public static IHostBuilder ConfigureDefaults(this IHostBuilder builder, string[] args);
    }
}

[davidfowl]

Nice!

[IEvangelist]

If you're okay with it @maryamariyan and @davidfowl, I'd love to work on this?

[davidfowl]

Do it!