Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.FileProviders.Physical.Tests Failing With DirectoryNotFoundException #44626

Closed
steveisok opened this issue Nov 13, 2020 · 6 comments · Fixed by #44651
Closed
Assignees
Labels
area-Extensions-FileSystem test-bug Problem in test source code (most likely)
Milestone

Comments

@steveisok
Copy link
Member

I'm seeing intermittent failures across both runtimes that end up with the following exception:

Unhandled Exception:
System.IO.DirectoryNotFoundException: Could not find a part of the path '/tmp/gq0eerpt.0j2'.
   at System.IO.Enumeration.FileSystemEnumerator`1[[System.IO.FileSystemInfo, System.IO.FileSystem, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].CreateDirectoryHandle(String path, Boolean ignoreNotFound) in /_/src/libraries/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Unix.cs:line 79
   at System.IO.Enumeration.FileSystemEnumerator`1[[System.IO.FileSystemInfo, System.IO.FileSystem, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].Init() in /_/src/libraries/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Unix.cs:line 39
   at System.IO.Enumeration.FileSystemEnumerator`1[[System.IO.FileSystemInfo, System.IO.FileSystem, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]..ctor(String directory, Boolean
...

Here's a helix log from 44611 for reference.

This seemed to have happened at least 16 times in the last day.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Nov 13, 2020
@danmoseley
Copy link
Member

@eerhardt I can't look right now but didn't this recently change to stop polling? Maybe that made this more common?

@eerhardt
Copy link
Member

eerhardt commented Nov 13, 2020

These tests were just changed with #41426.

cc @ericstj @maryamariyan

@ghost
Copy link

ghost commented Nov 13, 2020

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
Description:

I'm seeing intermittent failures across both runtimes that end up with the following exception:

Unhandled Exception:
System.IO.DirectoryNotFoundException: Could not find a part of the path '/tmp/gq0eerpt.0j2'.
   at System.IO.Enumeration.FileSystemEnumerator`1[[System.IO.FileSystemInfo, System.IO.FileSystem, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].CreateDirectoryHandle(String path, Boolean ignoreNotFound) in /_/src/libraries/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Unix.cs:line 79
   at System.IO.Enumeration.FileSystemEnumerator`1[[System.IO.FileSystemInfo, System.IO.FileSystem, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].Init() in /_/src/libraries/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Unix.cs:line 39
   at System.IO.Enumeration.FileSystemEnumerator`1[[System.IO.FileSystemInfo, System.IO.FileSystem, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]..ctor(String directory, Boolean
...

Here's a helix log from 44611 for reference.

This seemed to have happened at least 16 times in the last day.

Author: steveisok
Assignees: -
Labels:

area-Extensions-FileSystem, untriaged

Milestone: -

@ericstj
Copy link
Member

ericstj commented Nov 13, 2020

I’ll fix this. I introduced with the inotify test. What’s happening is that the timer thread doesn’t fire until after the test is done and disposing the watcher didn’t successfully cancel it. I had a fix for this but pulled it out after I stopped seeing the problem. For now the quickest fix is to move inotify test to outer loop.

@ericstj ericstj self-assigned this Nov 13, 2020
@ericstj ericstj added test-bug Problem in test source code (most likely) blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' and removed untriaged New issue has not been triaged by the area owner labels Nov 13, 2020
@stephentoub stephentoub reopened this Nov 13, 2020
@stephentoub
Copy link
Member

stephentoub commented Nov 13, 2020

Reopening to track actually fixing the (now outerloop) test.

Related to #44652.

@stephentoub stephentoub removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Nov 13, 2020
@stephentoub stephentoub added this to the 6.0.0 milestone Nov 13, 2020
@ericstj
Copy link
Member

ericstj commented Nov 13, 2020

@stephentoub my intent was to use the new issue to track a better fix to the outerloop test.

@ericstj ericstj closed this as completed Nov 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-FileSystem test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants