Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-buffer sends in WebAssembly WebSockets #44611

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Support multi-buffer sends in WebAssembly WebSockets #44611

merged 4 commits into from
Nov 13, 2020

Conversation

BrennanConroy
Copy link
Member

Proposed fix for #44551

@BrennanConroy BrennanConroy added the arch-wasm WebAssembly architecture label Nov 12, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue meta data
Issue content: 
Proposed fix for https://github.com/dotnet/runtime/issues/44551

</td>
Issue author: BrennanConroy
Assignees: -
Labels: 
`arch-wasm`, `area-System.Net`

</td>
Milestone: -

@davidfowl
Copy link
Member

Memory stream.. someday we'll care about perf in the browser

lewing
lewing approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjpou1 please follow up with a test for this.

@lewing
Copy link
Member

lewing commented Nov 12, 2020 •
edited
Loading

@kg this should be on the list of the perf/bindings tests as well

@steveisok steveisok mentioned this pull request Nov 13, 2020
Closed
@halter73
Copy link
Member

At least this no longer allocates the MemoryStream for a single-frame message, but pooling would be nice.

@lewing
Copy link
Member

lewing commented Nov 13, 2020

@halter73 I had already opened #44614 to track other improvements.

@lewing
Copy link
Member

lewing commented Nov 13, 2020

Failures are unrelated and the FileProviders issue is resolved now.

@lewing lewing merged commit 57f2955 into dotnet:master Nov 13, 2020
@BrennanConroy
Copy link
Member Author

/backport to release/5.0

@BrennanConroy BrennanConroy deleted the brecon/wasmwebsockets branch November 13, 2020 21:09
@BrennanConroy BrennanConroy mentioned this pull request Nov 13, 2020
Closed
@github-actions
Copy link
Contributor

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/362325458

@github-actions github-actions bot mentioned this pull request Nov 13, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

@kjpou1 kjpou1 Awaiting requested review from kjpou1

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Net
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BrennanConroy @davidfowl @lewing @halter73 @karelz @Dotnet-GitSync-Bot