Threading.Tasks.DataFlow and ComponentModel.Annotations are not building NetCoreAppCurrent

[eerhardt]

These libraries are included in the shared framework, but we aren't building them for $(NetCoreAppCurrent).

runtime/src/libraries/System.Threading.Tasks.Dataflow/src/System.Threading.Tasks.Dataflow.csproj

Line 3 in 8a3fd5a

<TargetFrameworks>netstandard2.0;netstandard1.0;netstandard1.1;net461</TargetFrameworks>

runtime/src/libraries/System.ComponentModel.Annotations/src/System.ComponentModel.Annotations.csproj

Line 3 in 8a3fd5a

<TargetFrameworks>netstandard2.1</TargetFrameworks>

This causes the following problems:

1. These libraries have <Nullable>enable</Nullable> in them, but they are building against netstandard APIs, which don't have nullablility annotations.
2. When someone wants to use a new API (or new attributes, like DynamicDependency and UnconditionalSuppressMessage), they are not available.

We should add a $(NetCoreAppCurrent) target for these libraries, and ship that in the shared framework / runtimepack. I analyzed a recent shared framework, and these were the only 2 libraries (outside of System.Runtime.CompilerServices.Unsafe) that didn't target net6.0.

cc @LakshanF @joperezr @safern @ViktorHofer @ericstj

[ghost]

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

These libraries are included in the shared framework, but we aren't building them for $(NetCoreAppCurrent).

runtime/src/libraries/System.Threading.Tasks.Dataflow/src/System.Threading.Tasks.Dataflow.csproj

Line 3 in 8a3fd5a

<TargetFrameworks>netstandard2.0;netstandard1.0;netstandard1.1;net461</TargetFrameworks>

runtime/src/libraries/System.ComponentModel.Annotations/src/System.ComponentModel.Annotations.csproj

Line 3 in 8a3fd5a

<TargetFrameworks>netstandard2.1</TargetFrameworks>

This causes the following problems:

1. These libraries have <Nullable>enable</Nullable> in them, but they are building against netstandard APIs, which don't have nullablility annotations.
2. When someone wants to use a new API (or new attributes, like DynamicDependency and UnconditionalSuppressMessage), they are not available.

We should add a $(NetCoreAppCurrent) target for these libraries, and ship that in the shared framework / runtimepack. I analyzed a recent shared framework, and these were the only 2 libraries (outside of System.Runtime.CompilerServices.Unsafe) that didn't target net6.0.

cc @LakshanF @joperezr @safern @ViktorHofer @ericstj

Author:	eerhardt
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[eerhardt]

Just an FYI: I quickly tried doing this locally and System.ComponentModel.Annoations appears to be OK w.r.t. nullable annoations.

However, System.Threading.Tasks.DataFlow has a ~60 nullable annoation errors now that it compiles for NetCoreAppCurrent.