Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][tests][eat] System.Globalization.Tests.InvariantModeTests.IcuShouldNotBeLoaded #50727

Closed
radical opened this issue Apr 5, 2021 · 2 comments
Closed

[wasm][tests][eat] System.Globalization.Tests.InvariantModeTests.IcuShouldNotBeLoaded #50727

radical opened this issue Apr 5, 2021 · 2 comments
Assignees
@radical
Labels
arch-wasm WebAssembly architecture area-System.Globalization disabled-test The test is disabled in source code against the issue trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Milestone
6.0.0

Comments

@radical
Copy link
Member

radical commented Apr 5, 2021 

[02:18:21] fail: [FAIL] System.Globalization.Tests.InvariantModeTests.IcuShouldNotBeLoaded
[02:18:21] info: Assert.False() Failure
[02:18:21] info: Expected: False
[02:18:21] info: Actual:   True
[02:18:21] info:    at System.Globalization.Tests.InvariantModeTests.IcuShouldNotBeLoaded()
[02:18:21] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@radical radical added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT labels Apr 5, 2021
@ghost
Copy link

ghost commented Apr 5, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details 
[02:18:21] fail: [FAIL] System.Globalization.Tests.InvariantModeTests.IcuShouldNotBeLoaded
[02:18:21] info: Assert.False() Failure
[02:18:21] info: Expected: False
[02:18:21] info: Actual:   True
[02:18:21] info:    at System.Globalization.Tests.InvariantModeTests.IcuShouldNotBeLoaded()
[02:18:21] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Author: radical
Assignees: -
Labels:

arch-wasm, disabled-test, trimming-for-aot
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Globalization untriaged New issue has not been triaged by the area owner labels Apr 5, 2021
@radical radical self-assigned this Apr 6, 2021
radical added a commit to radical/runtime that referenced this issue Apr 7, 2021
@radical
[wasm][tests][aot] Propogate wasm properties from the original project
6e63861 
.. to the proxy project on helix.

This also fixes dotnet#50727 , by
correctly passing `$(InvariantGlobalization)` property to the proxy
project. So, re-enable `Invariant.Tests`.
@maryamariyan maryamariyan removed the untriaged New issue has not been triaged by the area owner label Apr 8, 2021
@maryamariyan maryamariyan added this to the 6.0.0 milestone Apr 8, 2021
@radical
Copy link
Member Author

radical commented Apr 26, 2021

Fixed on main.

@radical radical closed this as completed Apr 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-System.Globalization disabled-test The test is disabled in source code against the issue trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@radical @maryamariyan