FileSystemWatcher_DirectorySymbolicLink_TargetsFile_Fails #53366
Labels
Milestone
Comments
dotnet-issue-labeler
bot
added
the
untriaged
|
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
aik-jahoda
changed the title
aik-jahoda
changed the title
|
There is massive occurrence of failures, disabling the test. cc @jozkee |
|
Tagging subscribers to this area: @carlossanlop Issue DetailsStarted today. Runfo Tracking Issue: FileSystemWatcher_DirectorySymbolicLink_TargetsFile_Fails
Displaying 100 of 106 results Build Result Summary
|
|
@jozkee would it be possible to re-enable the test and fix it when you'll be working on other issues related to symbolic links and |
|
@jozkee @carlossanlop were you able to identify the source of the problem? Is this a product bug and we should fix it in 6.0? Or a flaky test and 7.0 should be fine? |
|
The issue is old enough that the failure results disappeared, so I can't be certain where the failure was happening. What I do know is that these new tests were added before the new symlink APIs were introduced, so it has its own logic to create unit tests, which may not be working correctly in Windows 10 if Developer Mode is not enabled. So there are two things that can be changed to ensure the tests are more reliable:
public void FileSystemWatcher_DirectorySymbolicLink_TargetsFile_Fails()
{
// Arrange
using var tempDir = new TempDirectory(GetTestFilePath());
string pathToTarget = Path.Join(tempDir.Path, Path.GetRandomFileName());
var dirLink = new DirectoryInfo(Path.Join(tempDir.Path, Path.GetRandomFileName()));
dirLink.CreateAsSymbolicLink(pathToTarget); // Create a dir link to a non-existent target (valid scenario)
var targetFile = new FileInfo(pathToTarget);
targetFile.Create().Dispose(); // Create the target as a file
using var watcher = new FileSystemWatcher(dirLink.FullName);
// Act - Assert
Assert.Throws<FileNotFoundException>(() => watcher.EnableRaisingEvents = true);
} |
|
@carlossanlop could you please send the PR with proposed changes? |
|
@carlossanlop This doesn't fail on creating the symlink. It fails when a directory symlink pointing to a file is passed to the FSW and I suggest we just remove the test since it is asserting what I think is windows undefined behavior, the undefined behavior is: "Open a directory symlink pointing to a file with CreateFileW". |
@jozkee is my understanding correct that the problem is that we might open a file (not a directory), using the following logic? If that is the case, we might want to verify if it's possible to enforce |
|
The problem is that |
50 tasks
carlossanlop
added
the
untriaged
jeffschwMSFT
removed
the
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Started today.
Runfo Tracking Issue: FileSystemWatcher_DirectorySymbolicLink_TargetsFile_Fails
Build Result Summary
The text was updated successfully, but these errors were encountered: