Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SimplePerfScore output, not scaled by block weights #53336

Closed
wants to merge 2 commits into from
Closed

Add SimplePerfScore output, not scaled by block weights #53336

wants to merge 2 commits into from

Conversation

BruceForstall
Copy link
Member

@BruceForstall BruceForstall commented May 27, 2021 •
edited
Loading

Example output:

;; bbWeight=0.63 PerfScore 13.02 PerfScoreSimple 20.75

This is useful when working on things that change the block weights, which then affect the perf scores greatly. If you want to just see how the unweighted perf scores change, you can look at PerfScoreSimple.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 27, 2021
@runfoapp runfoapp bot mentioned this pull request May 27, 2021
Open
@BruceForstall BruceForstall changed the title Add SimplePerfScore, not scaled by block weights Add SimplePerfScore output, not scaled by block weights May 28, 2021
@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib PTAL

AndyAyersMS
AndyAyersMS reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the IG weight is an IG invariant, seems like you only need to track the unweighted score and the weight in each IG?

Then the weighted score is just the product of the two.

Also do you want to accumulate full method unweighted scores?

@BruceForstall
Copy link
Member Author

Closing this for now

@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
@BruceForstall BruceForstall deleted the AddSimplePerfScore branch December 28, 2022 01:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS left review comments

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @AndyAyersMS