[Libraries][iOS/MacCatalyst/tvOS] IsIanaIdTest fails from mismatched expectation

[mdh1418]

In #57732, several TimeZoneInfoTests were tweaked to pass on iOS/MacCatalyst/tvOS. At the time, when running tests, America/Buenos_Aires was no recognized as an IanaID on iOS/MacCatalyst/tvOS, so that value was used instead of Pacific Standard Time which throws TimeZoneNotFound ahead of returning false for IsIanaId.

I'm not certain what is supposed to be a TimeZoneId and not IanaId on iOS/MacCatalyst/tvOS yet, and I'm not sure exactly what had changed between that change and the latest run on #57208 to cause it to no longer not be an IanaId.

The fix should simply be finding a known TimeZoneId on iOS/MacCatalyst/tvOS that is and will not be recognized as an IanaId.

---

From another glance with #58440 (comment), it appears that the failure is directly from this addition to the test

runtime/src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs

Line 2667 in faafb32

Assert.Equal((expected || TimeZoneInfo.Local.Id.Equals("Utc", StringComparison.OrdinalIgnoreCase)), TimeZoneInfo.Local.HasIanaId);

The newest check fails on iOS/MacCatalyst/tvOS as the TimeZoneInfo.Local.Id is America/New_York. The check expects for the TimeZoneInfo.Local.Id to be an Iana Id if the platform is NOT windows or if the Id is NOT UTC. It seems as though America/New_York is evaluated as not being an Iana Id.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In #57732, several TimeZoneInfoTests were tweaked to pass on iOS/MacCatalyst/tvOS. At the time, when running tests, America/Buenos_Aires was no recognized as an IanaID on iOS/MacCatalyst/tvOS, so that value was used instead of Pacific Standard Time which throws TimeZoneNotFound ahead of returning false for IsIanaId.

I'm not certain what is supposed to be a TimeZoneId and not IanaId on iOS/MacCatalyst/tvOS yet, and I'm not sure exactly what had changed between that change and the latest run on #57208 to cause it to no longer not be an IanaId.

The fix should simply be finding a known TimeZoneId on iOS/MacCatalyst/tvOS that is and will not be recognized as an IanaId.

Author:	mdh1418
Assignees:	-
Labels:	area-System.Globalization
Milestone:	7.0.0

[ghost]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In #57732, several TimeZoneInfoTests were tweaked to pass on iOS/MacCatalyst/tvOS. At the time, when running tests, America/Buenos_Aires was no recognized as an IanaID on iOS/MacCatalyst/tvOS, so that value was used instead of Pacific Standard Time which throws TimeZoneNotFound ahead of returning false for IsIanaId.

I'm not certain what is supposed to be a TimeZoneId and not IanaId on iOS/MacCatalyst/tvOS yet, and I'm not sure exactly what had changed between that change and the latest run on #57208 to cause it to no longer not be an IanaId.

The fix should simply be finding a known TimeZoneId on iOS/MacCatalyst/tvOS that is and will not be recognized as an IanaId.

Author:	mdh1418
Assignees:	-
Labels:	area-System.Runtime
Milestone:	7.0.0

[tarekgh]

@mdh1418 we had a bug which we have recently fixed it #58326. could be this is the reason?

[ghost]

Tagging subscribers to 'arch-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In #57732, several TimeZoneInfoTests were tweaked to pass on iOS/MacCatalyst/tvOS. At the time, when running tests, America/Buenos_Aires was no recognized as an IanaID on iOS/MacCatalyst/tvOS, so that value was used instead of Pacific Standard Time which throws TimeZoneNotFound ahead of returning false for IsIanaId.

I'm not certain what is supposed to be a TimeZoneId and not IanaId on iOS/MacCatalyst/tvOS yet, and I'm not sure exactly what had changed between that change and the latest run on #57208 to cause it to no longer not be an IanaId.

The fix should simply be finding a known TimeZoneId on iOS/MacCatalyst/tvOS that is and will not be recognized as an IanaId.

Author:	mdh1418
Assignees:	-
Labels:	area-System.Runtime, os-ios, os-tvos, os-maccatalyst
Milestone:	7.0.0

[mdh1418]

@tarekgh Ah it does look like the culprit instead of my original suspicion. It looks like on iOS/tvOS/MacCatalyst the TimeZoneInfo.Local.Id is America/New_York (atleast on my local machine), and so that is evaluated as having an Iana Id

[tarekgh]

Ah it does look like the culprit instead of my original suspicion. It looks like on iOS/tvOS/MacCatalyst the TimeZoneInfo.Local.Id is America/New_York (atleast on my local machine), and so that is evaluated as having an Iana Id

America/New_York is IANA Id. So, what you are seeing there is correct. So, still look to me the problem is in the test. right?

[mdh1418]

Right, the problem is the test itself, I'm thinking the right action would be to extend
expected || TimeZoneInfo.Local.Id.Equals("Utc", StringComparison.OrdinalIgnoreCase)
to
expected || PlatformDetection.IsiOS || PlatformDetection.IstvOS || TimeZoneInfo.Local.Id.Equals("Utc", StringComparison.OrdinalIgnoreCase)

I'll put up a PR

[tarekgh]

I am not sure why you need to add these extra conditions? Could you tell in detail what are the TZ Ids which fail on iOS or tvOS?

[mdh1418]

@tarekgh I updated the description since my first glance/assumption was incorrect.

Could you tell in detail what are the TZ Ids which fail on iOS or tvOS?

The only failure seems to be that iOS/MacCatalyst/tvOS has a TimeZoneInfo.Local.Id that is an Iana Id that is not UTC.
To me it seems like its a problem with the check specifically for iOS/MacCatalyst/tvOS.