NullabilityInfoContext returns incorrect result for parameter of private constructor in a public-only assembly

[madelson]

Description

See reproduction.

Reproduction Steps

        var context = new NullabilityInfoContext();
        // private IndexOutOfRangeException(SerializationInfo info, StreamingContext context)
        var constructor = typeof(IndexOutOfRangeException)
            .GetConstructor(BindingFlags.NonPublic | BindingFlags.Instance, new[] { typeof(SerializationInfo), typeof(StreamingContext) })!;
        var info = context.Create(constructor.GetParameters()[0]);
        Console.WriteLine(info.WriteState); // Nullable (should be Unknown)

        // printout includes System.Runtime.CompilerServices.NullablePublicOnlyAttribute
        Console.WriteLine(string.Join(", ", typeof(IndexOutOfRangeException).Module.GetCustomAttributes().Select(a => a.GetType())));

Expected behavior

Because of the NullablePublicOnlyAttribute, the parameter nullability for the reference type parameter on the private constructor should be Unknown.

Actual behavior

Returns Nullable.

Regression?

No response

Known Workarounds

No response

Configuration

VS 17.0.2, .NET 6, Windows 10 x64.

I don't have any reason to believe this is configuration specific.

Other information

I think the problem is this line in NullabilityInfoContext:

if (parameterInfo.Member is MethodInfo method && IsPrivateOrInternalMethodAndAnnotationDisabled(method))

Because ConstructorInfo is MethodBase but not MethodInfo, this check misses.

CC @Shane32

[ghost]

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

See reproduction.

Reproduction Steps

        var context = new NullabilityInfoContext();
        // private IndexOutOfRangeException(SerializationInfo info, StreamingContext context)
        var constructor = typeof(IndexOutOfRangeException)
            .GetConstructor(BindingFlags.NonPublic | BindingFlags.Instance, new[] { typeof(SerializationInfo), typeof(StreamingContext) })!;
        var info = context.Create(constructor.GetParameters()[0]);
        Console.WriteLine(info.WriteState); // Nullable (should be Unknown)

        // printout includes System.Runtime.CompilerServices.NullablePublicOnlyAttribute
        Console.WriteLine(string.Join(", ", typeof(IndexOutOfRangeException).Module.GetCustomAttributes().Select(a => a.GetType())));

Expected behavior

Because of the NullablePublicOnlyAttribute, the parameter nullability for the reference type parameter on the private constructor should be Unknown.

Actual behavior

Returns Nullable.

Regression?

No response

Known Workarounds

No response

Configuration

VS 17.0.2, .NET 6, Windows 10 x64.

I don't have any reason to believe this is configuration specific.

Other information

I think the problem is this line in NullabilityInfoContext:

if (parameterInfo.Member is MethodInfo method && IsPrivateOrInternalMethodAndAnnotationDisabled(method))

Because ConstructorInfo is MethodBase but not MethodInfo, this check misses.

CC @Shane32

Author:	madelson
Assignees:	-
Labels:	area-System.Reflection, untriaged
Milestone:	-