Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool for updating 3rd-party notices should be more resilient to changes in dependencies #74766

Open
NikolaMilosavljevic opened this issue Aug 29, 2022 · 2 comments

Comments

@NikolaMilosavljevic
Copy link
Member

Currently we have a list of repos that contribute TPNs and a commented out list of those that do not. These lists can change and the repo can onboard its own TPN file. Every such change would require modification of the tool, to uncomment the repo-specific entry.

<ItemGroup>
<TpnRepo Include="dotnet/runtime" />
<TpnRepo Include="dotnet/aspnetcore" />
<TpnRepo Include="dotnet/installer" />
<TpnRepo Include="dotnet/roslyn-analyzers" />
<TpnRepo Include="dotnet/templating" />
<TpnRepo Include="dotnet/winforms" />
<TpnRepo Include="dotnet/wpf" />
<!--
Additional repos that should be included but don't have any third-party-notices files:
dotnet/efcore
dotnet/emsdk
dotnet/extensions
dotnet/icu
dotnet/sdk
dotnet/windowsdesktop
dotnet/linker
-->

Instead of requiring manual tool changes, which can easily be overlooked, make a change to the tool to check all known repos and skip those that do not have TPNs onboarded.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 29, 2022
@NikolaMilosavljevic NikolaMilosavljevic added this to the 8.0.0 milestone Aug 31, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 31, 2022
@NikolaMilosavljevic
Copy link
Member Author

[Triage] We could use Darc dependencies, starting with installer, to discover all product repos.

@NikolaMilosavljevic NikolaMilosavljevic modified the milestones: 8.0.0, Future Sep 19, 2023
@akoeplinger
Copy link
Member

akoeplinger commented Jun 5, 2024

We also need to remove the dotnet/installer repo from this list now that it was merged into the sdk repo.
I tried adding the sdk repo instead but then the target complains because the TPN file in the sdk repo doesn't have any entries (which sounds like another issue?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants