-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update THIRD-PARTY-NOTICES file #74760
Update THIRD-PARTY-NOTICES file #74760
Conversation
@danmoseley is there anyone else that should review this? I've added owners of repos that contribute new notices for 7.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the auto-generator tool for TPN account for duplicates?
License for remote stack unwind (https://github.com/llvm/llvm-project/blob/main/lldb/source/Symbol/CompactUnwindInfo.cpp) | ||
-------------------------------------- | ||
|
||
Copyright 2019 LLVM Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of 471? (llvm-project notice covers llvm-project/libunwind as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably inevitable if we're aggregating them with a script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in second commit.
|
||
--------------------------------------------------------- | ||
|
||
Newtonsoft.Json 13.0.1 - MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of line 321?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in second commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future fix in the tool is tracked in #74775
It does skip duplicates - perhaps those are in existing baseline - will check. |
@@ -29,7 +30,6 @@ | |||
dotnet/icu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than hard code which don't have one, can the tool simply scan them all, and include what it finds? that way we don't have to remember to edit this later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created the issue to update the related tooling: #74766
Looking through the whole TPN:
|
Most of these are old, legacy notices that we've shipped for years. I believe a thorough cleanup is in order, and it should be done in 8.0, as it would touch many repos. Will create a tracking issue. |
@NikolaMilosavljevic is this good to merge? |
@tlakollo we have one new notice coming from Can you help us review the notice and sign-off if you're OK with it being included? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
Some checks are failing due to an unrelated issue - not sure if we should waste build resources by trying to get this clean. |
We have approval, sign offs, and the CI results have been checked: No need to restart. this change does not seem to affect the CI results. |
New sections for 7.0 release.
This update was auto-generated using a tool that harvests notices from all contributing repos. dotnet/linker is the only new repo added for 7.0 release.
Here are the new sections, sorted by repo:
dotnet/linker
License for Jb Evain
dotnet/runtime
License for remote stack unwind (https://github.com/llvm/llvm-project/blob/main/lldb/source/Symbol/CompactUnwindInfo.cpp)
License for sse4-strstr (https://github.com/WojciechMula/sse4-strstr)
License notice for amd/aocl-libm-ose
License notice for code from The Practice of Programming
License notice for m-ou-se/floatconv
License notice for MsQuic
Notice for Euclidean Affine Functions and Applications to Calendar Algorithms
dotnet/templating
Newtonsoft.Json 13.0.1 - MIT