Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Fix encoding problem when publishing with AOT #83035

Closed
ilonatommy opened this issue Mar 6, 2023 · 2 comments · Fixed by #83510
Closed

[browser] Fix encoding problem when publishing with AOT #83035

ilonatommy opened this issue Mar 6, 2023 · 2 comments · Fixed by #83510
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono wasm-aot-test WebAssembly AOT Test

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Mar 6, 2023

Follow-up for #82833. AOT case.

  • Add AOT tests the same way as in the previous PR
  • Fix wasm-ld : error : /root/helix/work/workitem/e/wbt/pztditip.fs4/obj/Debug/net8.0/browser-wasm/wasm/for-publish/driver.o: undefined symbol: mono_aot_module_build_publish_Debug煉_info
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono wasm-aot-test WebAssembly AOT Test labels Mar 6, 2023
@ilonatommy ilonatommy self-assigned this Mar 6, 2023
@ghost
Copy link

ghost commented Mar 6, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #82833. AOT case.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Build-mono, wasm-aot-test

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 6, 2023
@maraf
Copy link
Member

maraf commented Mar 6, 2023

We need to update multiple places

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 16, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Mar 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono wasm-aot-test WebAssembly AOT Test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants