Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Fix encoding problem when publishing with AOT #83510

Merged
merged 8 commits into from
Mar 21, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Mar 16, 2023

Fixes #83035.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono wasm-aot-test WebAssembly AOT Test labels Mar 16, 2023
@ilonatommy ilonatommy requested a review from maraf March 16, 2023 13:04
@ilonatommy ilonatommy self-assigned this Mar 16, 2023
@ghost
Copy link

ghost commented Mar 16, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #83035.

  • In native code we are checking if char is alphanumeric, if not we are replacing it with '_'. Unicode signs are treated as non-alphanumeric. To remain consistent, the same mechanism was added in the managed code, in FixupSymbolName.
  • MSBuild task's logger changes unicode's chars:
    Log.LogMessage(MessageImportance.High, $"[{count}/{_totalNumAssemblies}] {Path.GetFileName(assembly)} -> {copiedFiles}");

    e.g. -> _┼í┼»├ź
    so that we cannot compare the build/publish output in the old way (using string contains). String comparison with the result that is displayed by the console (_┼í┼»├ź) is not effective either, so now we are checking for a regex.
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Build-mono, wasm-aot-test

Milestone: -

@ilonatommy ilonatommy marked this pull request as draft March 16, 2023 16:03
@ilonatommy ilonatommy marked this pull request as ready for review March 17, 2023 11:48
@ilonatommy
Copy link
Member Author

Failures not related, merging.

@ilonatommy ilonatommy merged commit 93dda3b into dotnet:main Mar 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono wasm-aot-test WebAssembly AOT Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[browser] Fix encoding problem when publishing with AOT
2 participants