Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Handle liveness for defined retbufs in physical promotion #86711

Closed
Tracked by #76928
jakobbotsch opened this issue May 24, 2023 · 1 comment · Fixed by #104551
Closed
Tracked by #76928

JIT: Handle liveness for defined retbufs in physical promotion #86711

jakobbotsch opened this issue May 24, 2023 · 1 comment · Fixed by #104551
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@jakobbotsch
Copy link
Member

Physical promotion's liveness is overly conservative for this case currently as it does not have easy access to the parent GenTreeCall* and does not know how much of the retbuf will be defined.
@jakobbotsch jakobbotsch self-assigned this May 24, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 24, 2023
@jakobbotsch jakobbotsch added this to the Future milestone May 24, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 24, 2023
@ghost
Copy link

ghost commented May 24, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Physical promotion's liveness is overly conservative for this case currently as it does not have easy access to the parent GenTreeCall* and does not know how much of the retbuf will be defined.

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch removed the untriaged New issue has not been triaged by the area owner label May 26, 2023
@jakobbotsch jakobbotsch mentioned this issue May 28, 2023
Closed
40 tasks
@jakobbotsch jakobbotsch modified the milestones: Future, 9.0.0 Jul 8, 2024
@jakobbotsch jakobbotsch added Priority:2 Work that is important, but not critical for the release and removed Priority:2 Work that is important, but not critical for the release labels Jul 8, 2024
@jakobbotsch jakobbotsch modified the milestones: 9.0.0, Future Jul 8, 2024
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Jul 8, 2024
@jakobbotsch
JIT: Handle retbuf definitions precise in physical promotion's liveness
7546409 
Fix dotnet#86711
@jakobbotsch jakobbotsch mentioned this issue Jul 8, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jul 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Handle retbuf definitions precisely in physical promotion's liveness jakobbotsch/runtime
1 participant
@jakobbotsch