Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage tests are failing #88867

Closed
jkoritzinsky opened this issue Jul 13, 2023 · 1 comment · Fixed by #88856
Closed

ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage tests are failing #88867

jkoritzinsky opened this issue Jul 13, 2023 · 1 comment · Fixed by #88856
Labels
area-System.Runtime.InteropServices blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab source-generator Indicates an issue with a source generator feature
Milestone
8.0.0

Comments

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Jul 13, 2023 •
edited by build-analysis bot
Loading

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=338823
Build error leg or test failing: ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage
Pull request: #88856

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=338823
Error message validated: ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/13/2023 10:10:12 PM UTC

Report

Build Definition Test Pull Request
339121 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88699
339118 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88797
339106 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #87583
339092 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #87930
339080 dotnet/runtime ComInterfaceGenerator.Unit.Tests.WorkItemExecution #88871
339084 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88872
339049 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88067
339064 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88869
339029 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88634
339024 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88650
339036 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88626
339009 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88864
338992 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage
338980 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88711
338930 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage
338944 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88753
338912 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88860
338894 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88188
338724 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88656
338860 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88457
338851 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #87583
338823 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88856
338820 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88859
338800 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88700
338797 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88802
338786 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88387
338769 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88782
338721 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88853
338708 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88852
338705 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88614
338696 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88052
338656 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #87260
338661 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88636
338650 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88851
338634 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88849
338647 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88753
338613 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88801
338600 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88847
338590 dotnet/runtime ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage #88723

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
39 39 39
@jkoritzinsky jkoritzinsky added area-System.Runtime.InteropServices blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' source-generator Indicates an issue with a source generator feature Known Build Error Use this to report build issues in the .NET Helix tab labels Jul 13, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 13, 2023
@ghost
Copy link

ghost commented Jul 13, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=338823
Build error leg or test failing: ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage
Pull request: #88856

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, blocking-clean-ci, source-generator, Known Build Error
Milestone: -

jkoritzinsky added a commit to jkoritzinsky/runtime that referenced this issue Jul 13, 2023
@jkoritzinsky
Fix dotnet#88867
d42fc74
@jkoritzinsky jkoritzinsky mentioned this issue Jul 13, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 13, 2023
@jkoritzinsky jkoritzinsky removed the untriaged New issue has not been triaged by the area owner label Jul 13, 2023
@jkoritzinsky jkoritzinsky added this to the 8.0.0 milestone Jul 13, 2023
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Jul 14, 2023
Merged
jkoritzinsky added a commit that referenced this issue Jul 14, 2023
@jkoritzinsky
Strip trivia from tokens. (#88856)
1deac17 
* Strip trivia from tokens.

Fixes #88798

* Move the trivia stripping into ContainingSyntax record constructor

* Make ContainingSyntax a regular struct with a primary constructor instead of a record struct.

* Fix #88867

* Suppress compiler diagnostics based on the linked issue.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime.InteropServices blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Strip trivia from tokens. jkoritzinsky/runtime
1 participant
@jkoritzinsky