Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][non-icu] Clean up ICU related files from runtime pack #99521

Closed
2 tasks done
mkhamoyan opened this issue Mar 11, 2024 · 3 comments
Closed
2 tasks done

[iOS][non-icu] Clean up ICU related files from runtime pack #99521

mkhamoyan opened this issue Mar 11, 2024 · 3 comments
Assignees
Milestone

Comments

@mkhamoyan
Copy link
Member

mkhamoyan commented Mar 11, 2024

Contributes to #80689

@mkhamoyan mkhamoyan added this to the 9.0.0 milestone Mar 11, 2024
@mkhamoyan mkhamoyan self-assigned this Mar 11, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@ivanpovazan
Copy link
Member

In this work could you please also remove the dependency on HybridGlobalization property from NativeAOT:

<NetCoreAppNativeLibrary Include="icudata" Condition="'$(_IsiOSLikePlatform)' == 'true' and '$(InvariantGlobalization)' != 'true' and '$(HybridGlobalization)' != 'true'" />
<NetCoreAppNativeLibrary Include="icui18n" Condition="'$(_IsiOSLikePlatform)' == 'true' and '$(InvariantGlobalization)' != 'true' and '$(HybridGlobalization)' != 'true'" />
<NetCoreAppNativeLibrary Include="icuuc" Condition="'$(_IsiOSLikePlatform)' == 'true' and '$(InvariantGlobalization)' != 'true' and '$(HybridGlobalization)' != 'true'" />

This affects users who are using NativeAOT iOS library mode.
If they don't set the property to true in their project files, it breaks their build because of missing references.

@mkhamoyan
Copy link
Member Author

This was done by #104443 and xamarin/xamarin-macios#20830

@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants