Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update r2r version and do any removals that we wanted to do at the next R2R minimum version bump #100310

Closed
wants to merge 4 commits into from

Conversation

davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Mar 26, 2024

Updates with new minimum R2R version

  • Remove CORINFO_HELP_FLTROUND and CORINFO_HELP_DBLROUND helpers
    • Remove the helpers
    • Remove the R2R enum values
    • Update the reflection tooling to understand that OLD versions of R2R binaries may have the rounding helpers, so the new reflection logic will continue to work

This PR serves as documentation of the exactg changes we want to make for the next R2R update PR

This is the PR associated with #98871 98871

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 26, 2024
@jkotas jkotas added area-ReadyToRun-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 26, 2024
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@@ -34,6 +34,7 @@
// R2R Version 9.0 adds support for the Vector512 type
// R2R Version 9.1 adds new helpers to allocate objects on frozen segments
// R2R Version 9.2 adds MemZero and NativeMemSet helpers
// R2R Version 10.0 changes the algorithm for statics layout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// R2R Version 10.0 changes the algorithm for statics layout
// R2R Version 10.0 changes the algorithm for statics layout
// R2R 10.0 is not compatible with 9.x or earlier

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants