Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set UseNativeAotForComponents for arm32 MUSL #103469

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

MichalStrehovsky
Copy link
Member

Not clear why we can't compute correct path to ILC, but this is failing official builds and we need to unblock.

error MSB3073: The command ""\tools\\ilc" @"/__w/1/s/artifacts/obj/cdacreader/Release/net9.0/linux-musl-arm/native/libcdacreader.ilc.rsp"" exited with code 127.

Not clear why we can't find path to ILC, but this is failing official builds and we need to unblock.

```
error MSB3073: The command ""\tools\\ilc" @"/__w/1/s/artifacts/obj/cdacreader/Release/net9.0/linux-musl-arm/native/libcdacreader.ilc.rsp"" exited with code 127.
```
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 14, 2024
@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@am11
Copy link
Member

am11 commented Jun 14, 2024

How does official build do things differently that it doesn't fail otherwise? Preview 5 has all these packages?

Please trigger the nativeaot pipeline in #103375 so we can see if that fixes it naturally.

@MichalStrehovsky
Copy link
Member Author

How does official build do things differently that it doesn't fail otherwise? Preview 5 has all these packages?

Please trigger the nativeaot pipeline in #103375 so we can see if that fixes it naturally.

We don't have any CI coverage for these legs. I triggered the outerloop but now I see it won't do anything for arm32 MUSL anyway.

This is failing in the official build when we're building runtime packs for native AOT (it's the same thing for the bionic legs).

The command it's running is:

/__w/1/s/build.sh -ci -arch arm -os linux -cross -s clr.nativeaotlibs+clr.nativeaotruntime+libs+packs -c Release /p:BuildNativeAOTRuntimePack=true /p:SkipLibrariesNativeRuntimePackages=true    /p:OfficialBuildId=20240614.2  

I'm pretty sure it found the package or restore would fail. We just don't compute the right path to it for whatever reason.

This shouldn't even be building the cdacreader, but the project injects itself into everything.

@MichalStrehovsky
Copy link
Member Author

On a different official build leg that runs

/__w/1/s/build.sh -ci -arch arm -os linux -cross -s clr.runtime+clr.alljits+clr.corelib+clr.nativecorelib+clr.tools+clr.aot+clr.packages+libs+host+packs -c Release    /p:OfficialBuildId=20240614.2  

it does seem to succeed.

For context, we didn't have a successful official build for more than a week (publicly you can see there's no dotnet/runtime flow to dotnet/sdk). This is now the top issue that blocks from reaching the other broken parts that other people are trying to fix. If this doesn't work, we'll need to do rollbacks and try again at a less sensitive time.

Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@am11
Copy link
Member

am11 commented Jun 14, 2024

Since src/native/managed is likely to have more projects in the future, we may want to make the properties resolution deterministic. (I tested the build on alpine armv7 and it was working then)

@MichalStrehovsky
Copy link
Member Author

/ba-g restore errors unrelated

@MichalStrehovsky MichalStrehovsky merged commit f1f0750 into main Jun 14, 2024
157 of 169 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch June 14, 2024 14:31
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Jun 14, 2024
@am11 am11 mentioned this pull request Jun 15, 2024
MichalStrehovsky added a commit that referenced this pull request Jun 15, 2024
* Revert "Do not set UseNativeAotForComponents for arm32 MUSL (#103469)"

This reverts commit f1f0750.

* Revert "Set UseNativeAotForComponents to false on bionic (#103454)"

This reverts commit d901213.

* Revert "Try fixing x86 Windows legs (#103411)"

This reverts commit 6927fea.

* Revert "Consolidate <NativeAotSupported definitions (#103273)"

This reverts commit b86c463.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants