Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Formats.Nrbf to the windowsdesktop transport package #103629

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ViktorHofer
Copy link
Member

Unblocks the windowsdesktop dependency flow. See dotnet/windowsdesktop#4459 (comment)

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ViktorHofer
Copy link
Member Author

@carlossanlop FYI, this change needs to go in before we snap

@carlossanlop
Copy link
Member

Thanks for the heads up. Will keep it in mind. The snap is tomorrow Wednesday at 4pm PT.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jun 18, 2024

CI taking more than 4 hours. That's problematic when trying to get changes like this one in.

@lewing
Copy link
Member

lewing commented Jun 18, 2024

CI taking more than 4 hours. That's problematic when trying to get changes like this one in.

you will end up waiting even longer for an official build :(

@am11
Copy link
Member

am11 commented Jun 18, 2024

browser-wasm leg stuck at Determining projects to restore... (for 55 mins)

unlucky build 🥲

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jun 18, 2024

/ba-g we waited long enough and we really need to get this in asap for P6

@ViktorHofer ViktorHofer merged commit 91f1481 into main Jun 18, 2024
72 of 83 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-2 branch June 18, 2024 19:19
@adamsitnik adamsitnik added the binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it label Jun 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants