Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x64][SysV] Classify empty structs for passing like padding #103799

Merged
merged 4 commits into from
Jun 28, 2024
Merged

[x64][SysV] Classify empty structs for passing like padding #103799

merged 4 commits into from
Jun 28, 2024

Commits on Jun 21, 2024

  1. Classify empty structs on x64 like padding 

    The current implementation barred a struct containing empty struct fields from enregistration. This did not match the [System V ABI](https://refspecs.linuxbase.org/elf/x86_64-abi-0.99.pdf) which says "NO_CLASS This class is used as initializer in the algorithms. It will be used for padding and **empty structures** and unions". It also does not match the behavior of GCC & Clang on Linux.
    @tomeksowi
    tomeksowi committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    aba87b6 View commit details
    Browse the repository at this point in the history

  2. Add comment to fix JIT to AssignClassifiedEightByteTypes

    @tomeksowi
    tomeksowi committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    131a3c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Add tests for empty struct field passing on System V

    @tomeksowi
    tomeksowi committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cb22839 View commit details
    Browse the repository at this point in the history

  2. Update field names in C++ tests to match C#

    @tomeksowi
    tomeksowi committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    db406a7 View commit details
    Browse the repository at this point in the history