Fix superpmi collect failure for crossgen2 on linux x64 and windows x86 #104181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Can you share a test run of the superpmi-collect pipeline with these changes (and a different JIT-EE guid to avoid overwriting existing collections)? |
JulieLeeMSFT
changed the title
…windows x86 failure becasue ilc.exe in partition 0 does not have any managed assemblies in it.
JulieLeeMSFT
force-pushed
the
spmiCollect
branch
from
64c3dd3
to
150038f
Compare
This was referenced Jul 14, 2024
Open
jakobbotsch
reviewed
Jul 15, 2024
| @@ -183,6 +183,7 @@ | |||
| "vcruntime140.dll", | |||
| "vcruntime140_1.dll", | |||
| "xunit.console.exe", | |||
| "ilc.exe" | |||
There was a problem hiding this comment.
Nit: the list looks sorted, so can you place this after ilasm?
|
@dotnet/jit-contrib, @jkoritzinsky, @jakobbotsch, it is ready to review. |
jkoritzinsky
approved these changes
Jul 16, 2024
jakobbotsch
approved these changes
Jul 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spmi collect pipeline started to fail since Feb'24 for crossgen2 on linux x64. Fix by including HelixRuntimeRid and download Dotnet Cli.
Edit: libraries crossgen2 was failing on windows x86 as well on partition 0 where it contained only ilc.exe. Fixed by ignoring ilc.exe because it does not have any assemblies to crossgen to.
cc @jkoritzinsky. PTAL.