Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][swift-interop] Enable SwiftInvalidCallConv tests on Mono runtime #104254

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Jul 1, 2024

The SwiftInvalidCallConv tests were disabled but are passing locally, let's enable them.

x64 miniJIT CI result:

10:55:52.539 Running test: Interop/Swift/SwiftInvalidCallConv/SwiftInvalidCallConv/SwiftInvalidCallConv.cmd

Return code:      0
Raw output file:      /tmp/helix/working/A38F08F5/w/BA040A13/uploads/Swift/SwiftInvalidCallConv/SwiftInvalidCallConv/output.txt
Raw output:
BEGIN EXECUTION
/tmp/helix/working/A38F08F5/p/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true SwiftInvalidCallConv.dll ''
Expected: 100
Actual: 100
END EXECUTION - PASSED
Test Harness Exitcode is : 0
To run the test:
Set up CORE_ROOT and run.
> /private/tmp/helix/working/A38F08F5/w/BA040A13/e/Interop/Interop/../Swift/SwiftInvalidCallConv/SwiftInvalidCallConv/SwiftInvalidCallConv.sh
10:55:52.722 Passed test: Interop/Swift/SwiftInvalidCallConv/SwiftInvalidCallConv/SwiftInvalidCallConv.cmd

Copy link
Contributor

Tagging subscribers to this area: @directhex, @matouskozak
See info in area-owners.md if you want to be subscribed.

@matouskozak
Copy link
Member Author

I've misread the condition, the tests are actually disabled for CoreCLR not Mono because CoreCLR does return System.Runtime.InteropServices.MarshalDirectiveException instead of System.InvalidProgramException for TestFuncWithNonPrimitiveArg test. I'll close this PR and update the tracking issue #93631

@matouskozak matouskozak closed this Jul 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants