[RISC-V] Increase timeout for tracing/eventcounter/runtimecounters #104461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
jakobbotsch
reviewed
Jul 5, 2024
| @@ -104,7 +104,7 @@ public static int TestEntryPoint() | |||
| // Create an EventListener. | |||
| using (RuntimeCounterListener myListener = new RuntimeCounterListener()) | |||
| { | |||
| Thread.Sleep(3000); | |||
| Thread.Sleep(60000); | |||
There was a problem hiding this comment.
A 1 minute sleep in an inner loop test seems like too much. Is there some to wait exactly until the counters are ready?
There was a problem hiding this comment.
What do you think about smth like this?
// Create an EventListener.
using (RuntimeCounterListener myListener = new RuntimeCounterListener())
{
// Wait max 60 seconds
for (int i = 0; i < 60; i++)
{
Thread.Sleep(1000);
if (myListener.Verify())
{
Console.WriteLine("Test passed");
return 100;
}
}
Console.WriteLine($"Test Failed - did not see one or more of the expected runtime counters.");
return 1;
}There was a problem hiding this comment.
Checked version from #104461 (comment) with checked build on riscv64 VisionFive2:
Did not see cpu-usage
Saw cpu-usage
Saw working-set
Saw gc-heap-size
Saw gen-0-gc-count
Saw gen-1-gc-count
Saw gen-2-gc-count
Saw threadpool-thread-count
Saw monitor-lock-contention-count
Saw threadpool-queue-length
Saw threadpool-completed-items-count
Saw alloc-rate
Saw active-timer-count
Saw gc-fragmentation
Saw gc-committed
Saw exception-count
Saw time-in-gc
Saw gen-0-size
Saw gen-1-size
Saw gen-2-size
Saw loh-size
Saw poh-size
Saw assembly-count
Saw il-bytes-jitted
Saw methods-jitted-count
Saw time-in-jit
Saw gen-0-gc-budget
Saw total-pause-time-by-gc
Test passed
If you think that approach from #104461 (comment) is ok, I'll update PR.
There was a problem hiding this comment.
I'm not familiar with this part of the runtime... we'll probably have to wait for @tommcdon once the US holiday is over.
There was a problem hiding this comment.
I do not have objections to the approach listed in #104461 (comment). Adding @noahfalk @hoyosjs for additional thoughts.
t-mustafin
approved these changes
Jul 8, 2024
RISC-V qemu-prio1-checked: 9343 / 9346 (99.97%)FailedKilledSkipped |
tomeksowi
approved these changes
Jul 10, 2024
RISC-V starfive-prio1-checked: 9327 / 9346 (99.80%)FailedKilledSkipped |
RISC-V qemu-prio1-checked: 9343 / 9346 (99.97%)FailedKilledSkipped |
RISC-V starfive-prio1-checked: 9327 / 9346 (99.80%)FailedKilledSkipped |
clamp03
approved these changes
Jul 12, 2024
This test expects that all runtime counters are already prepared when timeout has passed, however, it might be untrue for debug/checked builds and for VisionFive2 (riscv64).
gbalykov
force-pushed
the
increase-timeout-runtimecounters
branch
from
f507f2f
to
06b308b
Compare
noahfalk
approved these changes
Jul 12, 2024
This was referenced Jul 12, 2024
Open
tomeksowi
approved these changes
Jul 16, 2024
|
Can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test expects that all runtime counters are already prepared when timeout has passed, however, it might be untrue for debug/checked builds (specifically, debug/checked build on VisionFive2 riscv64).
Part of #84834, cc @dotnet/samsung