Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][infra] Remove Mono LLVMJIT builds #104552

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Jul 8, 2024

Mono no longer uses LLVM JIT backend and uses regular mini JIT instead.

The LLVMJIT jobs were completely removed from the runtime-llvm and runtime-official CI and refactored into regular Mono product builds for runtime.

Additionally, make AOT and fullAOT jobs Release only (both PR and rolling builds).

Copy link
Contributor

Tagging subscribers to this area: @directhex, @matouskozak
See info in area-owners.md if you want to be subscribed.

@matouskozak
Copy link
Member Author

/azp run runtime-llvm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matouskozak
Copy link
Member Author

/azp run runtime-llvm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matouskozak matouskozak marked this pull request as ready for review July 16, 2024 15:49
@akoeplinger
Copy link
Member

Are you going to work on removing LLVMJIT from the mono runtime too?

@matouskozak
Copy link
Member Author

Are you going to work on removing LLVMJIT from the mono runtime too?

I wasn't planning to. I thought that @radekdoulik was trying to remove that as part of LLVM 19 bump #103585 ?

@akoeplinger
Copy link
Member

akoeplinger commented Jul 17, 2024

Yeah it needed to be disabled in that PR but I think we could strip it out completely in a separate PR too.

@matouskozak
Copy link
Member Author

/azp run runtime-llvm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matouskozak matouskozak merged commit c4e32db into dotnet:main Jul 18, 2024
156 checks passed
@radekdoulik
Copy link
Member

Are you going to work on removing LLVMJIT from the mono runtime too?

I wasn't planning to. I thought that @radekdoulik was trying to remove that as part of LLVM 19 bump #103585 ?

We are making the runtime build the LLVM JIT without errors in that PR so far. It removes existing optimizations, which used legacy pass manager.

Given that this configuration (LLVM/JIT) is not used anymore, we can probably just strip it as @akoeplinger says.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants