don't rely on error code returned on Windows Nano #104973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
added
area-System.Diagnostics.Process
test-enhancement
This was referenced Jul 16, 2024
Open
jkotas
approved these changes
Jul 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, Windows Nano used to return
ERROR_SUCCESSwhen we were starting a file that was not an executable ( #17919)Recently it started to return
ERROR_TOO_MANY_POSTS: Too many posts were made to a semaphore.Which does not make any sense to me. Since the most important thing is to ensure that
Win32Exceptionis being thrown, I've modified the test to verify that for all Windows versions and check the error code for non-Nano versions.fixes #104770