Include new warning codes in --notrimwarn and --noaotwarn #105049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
MichalStrehovsky
approved these changes
Jul 17, 2024
| @@ -0,0 +1,41 @@ | |||
| using System.Diagnostics.CodeAnalysis; | |||
There was a problem hiding this comment.
I started from a copy of an existing test that didn't have a copyright header. A lot of our tests don't - I guess that should be fixed.
This was referenced Jul 18, 2024
Open
vitek-karas
reviewed
Jul 18, 2024
| @@ -227,9 +229,9 @@ public static class DiagnosticIdExtensions | |||
| 2103 => MessageSubCategory.TrimAnalysis, | |||
| 2106 => MessageSubCategory.TrimAnalysis, | |||
| 2107 => MessageSubCategory.TrimAnalysis, | |||
| >= 2109 and <= 2121 => MessageSubCategory.TrimAnalysis, | |||
| >= 2109 and <= (int) DiagnosticId._EndTrimAnalysisWarningsSentinel => MessageSubCategory.TrimAnalysis, | |||
There was a problem hiding this comment.
Technically this should be just <
| @@ -187,6 +187,7 @@ public enum DiagnosticId | |||
| _unused_DynamicallyAccessedMembersOnTypeReferencesCompilerGeneratedMemberOnBase = 2120, | |||
| RedundantSuppression = 2121, | |||
| TypeNameIsNotAssemblyQualified = 2122, | |||
| _EndTrimAnalysisWarningsSentinel = 2123, | |||
There was a problem hiding this comment.
Would it be better to not specify the value - AFAIK C# should assign the next (+1) value automatically which would make this work nicely when we add a new one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105044