Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] JIT: Testing field-wise analysis #105162

Closed
wants to merge 72 commits into from
Closed

[Draft] JIT: Testing field-wise analysis #105162

wants to merge 72 commits into from

Commits on Jul 15, 2024

  1. initial prototype

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1b0e3d3 View commit details
    Browse the repository at this point in the history

  2. Morph ARR_LENGTH and INDEX_ADDR

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    57b7e42 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect array length storage

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1b5b25e View commit details
    Browse the repository at this point in the history

  4. Use offset and correct type

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    395b735 View commit details
    Browse the repository at this point in the history

  5. handle reassignment

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    17de70b View commit details
    Browse the repository at this point in the history

  6. range check

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5443c42 View commit details
    Browse the repository at this point in the history

  7. throw range check failure

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b2d07da View commit details
    Browse the repository at this point in the history

  8. update comments

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b5ae9e7 View commit details
    Browse the repository at this point in the history

  9. add metrics

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    87b29de View commit details
    Browse the repository at this point in the history

  10. minor cleanup

    @hez2010
    hez2010 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    eeb681d View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Introduce new temp and implement local address morphing

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dee9f38 View commit details
    Browse the repository at this point in the history

  2. handle index out-of-range

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    94c103b View commit details
    Browse the repository at this point in the history

  3. Refactor to remove duplicates

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    12b297b View commit details
    Browse the repository at this point in the history

  4. Remove invalid asserts

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e0fa91e View commit details
    Browse the repository at this point in the history

  5. make compiler happy

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9e0a04f View commit details
    Browse the repository at this point in the history

  6. Address review feedbacks

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ae822f8 View commit details
    Browse the repository at this point in the history

  7. Fix INDEX_ADDR and add Sub

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a4588bb View commit details
    Browse the repository at this point in the history

  8. Support IsAddressLessThan and its friends

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    32b9e26 View commit details
    Browse the repository at this point in the history

  9. Fix assertions

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    39d1ad9 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/main' into value-array-stack-alloc

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0df0d58 View commit details
    Browse the repository at this point in the history

  11. Use new overload

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9f408b2 View commit details
    Browse the repository at this point in the history

  12. JIT: Remove GTF_IND_INVARIANT and GTF_IND_NONFAULTING flags checking 

    These flags are strictly optimizations. Having them required to be set
for certain indirs based on context of the operand introduces IR
invariants that are annoying to work with since it suddenly becomes
necessary for all transformations to consider "did we just introduce
this IR shape?". Instead, handle these patterns during morph as the
optimization it is and remove the strict flags checking from
`fgDebugCheckFlags`.
    @jakobbotsch
    jakobbotsch committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    418a62b View commit details
    Browse the repository at this point in the history

  13. Remove old comment

    @jakobbotsch
    jakobbotsch committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4572408 View commit details
    Browse the repository at this point in the history

  14. Expose jitconfig

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9255762 View commit details
    Browse the repository at this point in the history

  15. Remove another assert

    @jakobbotsch
    jakobbotsch committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1af84b9 View commit details
    Browse the repository at this point in the history

  16. Count

    @jakobbotsch
    jakobbotsch committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    629c793 View commit details
    Browse the repository at this point in the history

  17. Try 2 at counting

    @jakobbotsch
    jakobbotsch committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b578203 View commit details
    Browse the repository at this point in the history

  18. Introduce BBF_HAS_NEWARR

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b4445f6 View commit details
    Browse the repository at this point in the history

  19. Early exit on debug as well

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    af9c40e View commit details
    Browse the repository at this point in the history

  20. Update computed flags

    @hez2010
    hez2010 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8b54f5a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge remote-tracking branch 'jakobbotsch/indir-flags' into value-arr… 

    …ay-stack-alloc
    @hez2010
    hez2010 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cba4d2c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into value-array-stack-alloc

    @hez2010
    hez2010 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b497fae View commit details
    Browse the repository at this point in the history

  3. Partially revert 39d1ad9

    @hez2010
    hez2010 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6eca58d View commit details
    Browse the repository at this point in the history

  4. Reuse existing comma node

    @hez2010
    hez2010 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    49d8509 View commit details
    Browse the repository at this point in the history

  5. Respect IsBoundsChecked

    @hez2010
    hez2010 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    4c6e359 View commit details
    Browse the repository at this point in the history

  6. Check lowerbound too

    @hez2010
    hez2010 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    4d84379 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Fix assertion take 2

    @hez2010
    hez2010 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c0cad85 View commit details
    Browse the repository at this point in the history

  2. Remove redundant jit-ee calls

    @hez2010
    hez2010 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d28553a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into value-array-stack-alloc

    @hez2010
    hez2010 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f42e78f View commit details
    Browse the repository at this point in the history

  4. Fix assertion again

    @hez2010
    hez2010 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c21c4f7 View commit details
    Browse the repository at this point in the history

  5. Check array length

    @hez2010
    hez2010 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    18ec558 View commit details
    Browse the repository at this point in the history

  6. Fix assertion in another way

    @hez2010
    hez2010 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    eadb4ad View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Unset the flag to avoid unnecessary assert

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9d4021c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into value-array-stack-alloc

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1cba8c0 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1fff53e View commit details
    Browse the repository at this point in the history

  4. sigh

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d521a94 View commit details
    Browse the repository at this point in the history

  5. Support R2R/NativeAOT

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    97ee2be View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into value-array-stack-alloc

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c66bdb8 View commit details
    Browse the repository at this point in the history

  7. Fix building

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5bcb786 View commit details
    Browse the repository at this point in the history

  8. cleanup

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a01562e View commit details
    Browse the repository at this point in the history

  9. remove invalid assert

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e728d4f View commit details
    Browse the repository at this point in the history

  10. double align on 32bit platform

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d73c5c5 View commit details
    Browse the repository at this point in the history

  11. Use correct alignment for align8

    @hez2010
    hez2010 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c9fea23 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Fix intrinsic expansion

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    772bee6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into value-array-stack-alloc

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    499ac0b View commit details
    Browse the repository at this point in the history

  3. Initial prototype

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    3dbe8ac View commit details
    Browse the repository at this point in the history

  4. handle delegates

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    9022078 View commit details
    Browse the repository at this point in the history

  5. handle escape through IND

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    ada0890 View commit details
    Browse the repository at this point in the history

  6. Disable stackalloc for arrays and delegates

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    9f40866 View commit details
    Browse the repository at this point in the history

  7. Track conditional field assignment

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    bf58c6d View commit details
    Browse the repository at this point in the history

  8. Refine field-wise analysis

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    1faa8d9 View commit details
    Browse the repository at this point in the history

  9. Disable arrays and delegates

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    3b24b7a View commit details
    Browse the repository at this point in the history

  10. Remove invalid assert

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    b3dcc12 View commit details
    Browse the repository at this point in the history

  11. Minor enhancement

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    94966d1 View commit details
    Browse the repository at this point in the history

  12. Check type

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    8f0ef52 View commit details
    Browse the repository at this point in the history

  13. rollback

    @hez2010
    hez2010 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    d3b8f57 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Refine analysis

    @hez2010
    hez2010 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    49e15bc View commit details
    Browse the repository at this point in the history

  2. Refine analysis

    @hez2010
    hez2010 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    878faa6 View commit details
    Browse the repository at this point in the history

  3. Fix format

    @hez2010
    hez2010 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    6931aff View commit details
    Browse the repository at this point in the history

  4. Fully tracking stores

    @hez2010
    hez2010 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    38ba808 View commit details
    Browse the repository at this point in the history

  5. Full tracking leftovers

    @hez2010
    hez2010 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    08e8fb2 View commit details
    Browse the repository at this point in the history

  6. More fixes

    @hez2010
    hez2010 committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    66fc46b View commit details
    Browse the repository at this point in the history