Build .NETCoreApp source gens in allconfigurations build #105247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
ViktorHofer
commented
Jul 22, 2024
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
ericstj
approved these changes
Jul 22, 2024
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| <ItemGroup Condition="'$(BuildTargetFramework)' != '$(NetCoreAppCurrent)' or '$(BuildTargetFramework)' == ''"> | |||
| <ProjectReference Include="oob-all.proj" SkipGetTargetFrameworkProperties="true" /> | |||
| <ProjectReference Include="oob-gen.proj" /> | |||
There was a problem hiding this comment.
nit: this references all library generators, not just OOB ones. You could name it all-gen.proj.
There was a problem hiding this comment.
It's the same with "oob-all.proj" which also references everything. I felt that it's better to follow the existing naming schema.
|
Failure is correctly reported on both Windows and Unix in the allconfigurations leg. Reverting the code change now.
|
Closed
3 tasks
This was referenced Jul 22, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100346