Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base 64 decoder, reject input when unused bits are not 0 #105262

Merged
merged 7 commits into from
Jul 26, 2024

Apply suggestions from code review

ff21def
Select commit
Loading
Failed to load commit list.
Merged

Base 64 decoder, reject input when unused bits are not 0 #105262

Apply suggestions from code review
ff21def
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime succeeded Jul 26, 2024 in 38m 5s

Build #20240725.152 had test failures

Details

Tests

  • Failed: 1 (0.00%)
  • Passed: 3,911,008 (98.08%)
  • Other: 76,516 (1.92%)
  • Total: 3,987,525

Annotations

Check failure on line 1 in tracing/eventcounter/runtimecounters/runtimecounters.cmd

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

tracing/eventcounter/runtimecounters/runtimecounters.cmd

Return code:      1
Raw output file:      C:hw9A8C0908wA2A50954uploadseventcounter
untimecountersoutput.txt
Raw output:
BEGIN EXECUTION
 "C:hw9A8C0908pcorerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false" -p "System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true"  runtimecounters.dll 
Saw cpu-usage
System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
   at System.Collections.Generic.Dictionary`2.KeyCollection.Enumerator.MoveNext()
   at RuntimeEventCounterTests.RuntimeCounterListener.Verify()
   at RuntimeEventCounterTests.TestRuntimeEventCounter.TestEntryPoint()
   at __GeneratedMainWrapper.Main()
Expected: 100
Actual: 101
END EXECUTION - FAILED
FAILED
Test failed. Trying to see if dump file was created in C:cores since 7/26/2024 6:40:42 AM
Test Harness Exitcode is : 1
To run the test:
Set up CORE_ROOT and run.
> C:hw9A8C0908wA2A50954e	racing	racing../eventcounter/runtimecounters/runtimecounters.cmd
Raw output
   at Xunit.Assert.True(Nullable`1 condition, String userMessage) in /_/src/Microsoft.DotNet.XUnitAssert/src/BooleanAsserts.cs:line 146
   at TestLibrary.OutOfProcessTest.RunOutOfProcessTest(String assemblyPath, String testPathPrefix)
   at Program.<<Main>$>g__TestExecutor9|0_10(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)