Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert exception throwing JIT helpers to managed code. #105671

Merged
merged 13 commits into from
Aug 2, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

No description provided.

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

src/coreclr/vm/ecall.cpp Outdated Show resolved Hide resolved
Remove CorInfoHelpSig and replace with BinderMethodID in macros.
Convert start up loading of managed JIT helpers to lazy model.
@AaronRobinsonMSFT
Copy link
Member Author

This is going to fail for R2R images during Module::RunEagerFixups() - see below. I wonder if this can be narrowed to be "valid" if the image is SPCL?

#ifdef _DEBUG
// Loading types during eager fixup is not a tested scenario. Make bugs out of any attempts to do so in a
// debug build. Use holder to recover properly in case of exception.
class ForbidTypeLoadHolder
{
public:
ForbidTypeLoadHolder()
{
BEGIN_FORBID_TYPELOAD();
}
~ForbidTypeLoadHolder()
{
END_FORBID_TYPELOAD();
}
}
forbidTypeLoad;
#endif

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review July 30, 2024 23:03
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@AaronRobinsonMSFT
Copy link
Member Author

/ba-g All unrelated failures.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 30b34e6 into dotnet:main Aug 2, 2024
150 of 159 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the hmf_jithelper_throws branch August 2, 2024 02:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants