[release/9.0-preview7] Add swiftcall signature check for `mono_class_try_get_swift_error_class` #105813

github-actions · 2024-08-01T15:27:16Z

Backport of #105408 to release/9.0-preview7

Customer Impact

Customer reported
Found internally

This is blocking the preview7 release for MAUI.
A sample MAUI iOS application crashes in Debug configuration when run on a physical device without this fix.
The code assumed that System.Runtime.InteropServices.Swift.SwiftError is always available in System.Private.CoreLib assembly which is not true as the type can be trimmed away if it is not referenced, which causes the crash.

Regression

Yes
No

This was introduced in: 4185f94

Testing

It was verified that by manually rooting System.Runtime.InteropServices.Swift.SwiftError the sample MAUI iOS application successfully runs.

Risk

Low.
This fix only affects Mono support for Apple targets and the loaded types are now properly null checked.
The Release app deployments are not affected and work as expected.

IMPORTANT: If this backport is for a servicing release, please verify that:

The PR target branch is release/X.0-staging, not release/X.0.
If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

ivanpovazan · 2024-08-01T15:43:23Z

/cc: @dalexsoto @Redth

jeffschwMSFT

lgtm. adding @mmitche and @carlossanlop for timeline

dalexsoto

Yes please, this is needed for out of the box MAUI apps to not crash on iOS devices

carlossanlop · 2024-08-01T17:07:13Z

The Build wasi-wasm windows Release WasmBuildTests leg failed with a seemingly unrelated infra failure:

Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk -> D:\a\_work\1\s\artifacts\packages\Release\Shipping\Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk.9.0.0-ci.nupkg
  Microsoft.NET.Sdk.WebAssembly.Pack -> D:\a\_work\1\s\artifacts\packages\Release\Shipping\Microsoft.NET.Sdk.WebAssembly.Pack.9.0.0-ci.nupkg
  
  
      Directory: D:\a\_work\1\s\src\mono\wasi
  
  
  Mode                 LastWriteTime         Length Name                                                                 
  ----                 -------------         ------ ----                                                                 
  d-----          8/1/2024   3:42 PM                wasi-sdk                                                             
  bin/wasm32-wasip1-threads-clang.exe: truncated gzip input
  tar.exe: Error exit delayed from previous errors.
D:\a\_work\1\s\src\mono\mono.proj(337,5): error MSB3073: The command "powershell -NonInteractive -command "& D:\a\_work\1\s\src\mono\wasi\\provision.ps1 -WasiSdkUrl https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-22/wasi-sdk-22.0.m-mingw64.tar.gz -WasiSdkVersion 22 -WasiSdkPath D:/a/_work/1/s/src/mono/wasi/wasi-sdk/ -WasiLocalPath D:\a\_work\1\s\src\mono\wasi\; Exit $LastExitCode "" exited with code 1.
##[error]src\mono\mono.proj(337,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command "powershell -NonInteractive -command "& D:\a\_work\1\s\src\mono\wasi\\provision.ps1 -WasiSdkUrl https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-22/wasi-sdk-22.0.m-mingw64.tar.gz -WasiSdkVersion 22 -WasiSdkPath D:/a/_work/1/s/src/mono/wasi/wasi-sdk/ -WasiLocalPath D:\a\_work\1\s\src\mono\wasi\; Exit $LastExitCode "" exited with code 1.

Build FAILED.

lewing · 2024-08-01T17:23:46Z

The Build wasi-wasm windows Release WasmBuildTests leg failed with a seemingly unrelated infra failure:

Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk -> D:\a\_work\1\s\artifacts\packages\Release\Shipping\Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk.9.0.0-ci.nupkg
  Microsoft.NET.Sdk.WebAssembly.Pack -> D:\a\_work\1\s\artifacts\packages\Release\Shipping\Microsoft.NET.Sdk.WebAssembly.Pack.9.0.0-ci.nupkg
  
  
      Directory: D:\a\_work\1\s\src\mono\wasi
  
  
  Mode                 LastWriteTime         Length Name                                                                 
  ----                 -------------         ------ ----                                                                 
  d-----          8/1/2024   3:42 PM                wasi-sdk                                                             
  bin/wasm32-wasip1-threads-clang.exe: truncated gzip input
  tar.exe: Error exit delayed from previous errors.
D:\a\_work\1\s\src\mono\mono.proj(337,5): error MSB3073: The command "powershell -NonInteractive -command "& D:\a\_work\1\s\src\mono\wasi\\provision.ps1 -WasiSdkUrl https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-22/wasi-sdk-22.0.m-mingw64.tar.gz -WasiSdkVersion 22 -WasiSdkPath D:/a/_work/1/s/src/mono/wasi/wasi-sdk/ -WasiLocalPath D:\a\_work\1\s\src\mono\wasi\; Exit $LastExitCode "" exited with code 1.
##[error]src\mono\mono.proj(337,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command "powershell -NonInteractive -command "& D:\a\_work\1\s\src\mono\wasi\\provision.ps1 -WasiSdkUrl https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-22/wasi-sdk-22.0.m-mingw64.tar.gz -WasiSdkVersion 22 -WasiSdkPath D:/a/_work/1/s/src/mono/wasi/wasi-sdk/ -WasiLocalPath D:\a\_work\1\s\src\mono\wasi\; Exit $LastExitCode "" exited with code 1.

Build FAILED.

this is tracked with a known issue #105290

carlossanlop · 2024-08-01T18:39:20Z

The next failure is a timeout in Build browser-wasm linux Release LibraryTests_Threading that affected System.IO and System.Text.Json tests:

[16:42:41] info: [PASS] System.IO.Tests.Directory_EnumFiles_str_str_so.SearchPatternWithDoubleDots_Core
[17:55:56] fail: Tests timed out. Killing driver service pid 79
[17:55:56] fail: Application has finished with exit code TIMED_OUT but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)

[17:11:40] info: [PASS] System.Text.Json.Serialization.Tests.NumberHandlingTestsDynamic.Unquoted_FloatingPointConstants_Read_Fail
[17:11:52] fail: Tests timed out. Killing driver service pid 80
[17:11:52] fail: Application has finished with exit code TIMED_OUT but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)

Apparently we have so many tests in those two areas that we're spending too much time running them. Maybe the timeout limit could be increased for those two?

Anyway, seems unrelated to this change.

carlossanlop · 2024-08-01T18:46:39Z

I suspect the two remaining legs are also struggling to execute those same tests and might timeout as well.

runtime (Build browser-wasm windows Release LibraryTests)
runtime (Build browser-wasm windows Release WasmBuildTests)

carlossanlop · 2024-08-01T19:22:51Z

A couple of failed legs got automatically re-run and now they passed.

There's only one remaining which seems to be stuck. Since we're short on time, and all other wasm and wasi legs already passed, I will fast-merge.

richaplinvs · 2024-08-02T13:10:35Z

Is there more we can do help diagnose this as a consumer? I found nothing in the application output and nothing in the Apple crash logs. i.e. Is there something we can enable on top of debug to get more verbose output.

ivanpovazan · 2024-08-05T14:34:39Z

Is there more we can do help diagnose this as a consumer? I found nothing in the application output and nothing in the Apple crash logs. i.e. Is there something we can enable on top of debug to get more verbose output.

I am looking into how to improve diagnostics around such crashes, will provide an update once I have one. Thank you for understanding.

ivanpovazan · 2024-08-07T09:05:07Z

@richaplinvs we found the issue and I opened #106064 to track it.

kotlarmilos added 2 commits August 1, 2024 15:27

Add signature check for swiftcall

076d417

Handle null values for swift_error_ptr

d9dd706

github-actions bot requested review from BrzVlad, kotlarmilos, lambdageek, steveisok and thaystg as code owners August 1, 2024 15:27

dotnet-issue-labeler bot added the area-VM-meta-mono label Aug 1, 2024

jeffschwMSFT approved these changes Aug 1, 2024

View reviewed changes

jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Aug 1, 2024

jeffschwMSFT added this to the 9.0.0 milestone Aug 1, 2024

lambdageek approved these changes Aug 1, 2024

View reviewed changes

dalexsoto approved these changes Aug 1, 2024

View reviewed changes

jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 1, 2024

carlossanlop merged commit 61126f5 into release/9.0-preview7 Aug 1, 2024
79 of 88 checks passed

carlossanlop deleted the backport/pr-105408-to-release/9.0-preview7 branch August 1, 2024 19:23

This was referenced Aug 1, 2024

[wasm] Timeout in System.Text.Json.Tests #101204

Open

[browser][MT] test failure: Tests timed out. Killing driver service #103524

Open

Wasi provisioning failing #105290

Open

[browser] Unable to evaluate script: tab crashed #103623

Open

This was referenced Aug 2, 2024

Maui Blazor Hybrid app crashes on connected device after splash screen, but works on simulator #105421

Closed

.NET 9, Preview 6 Doesn't run on real iOS device microsoft/vscode-dotnettools#1282

Closed

github-actions bot locked and limited conversation to collaborators Sep 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/9.0-preview7] Add swiftcall signature check for `mono_class_try_get_swift_error_class` #105813

[release/9.0-preview7] Add swiftcall signature check for `mono_class_try_get_swift_error_class` #105813

github-actions bot commented Aug 1, 2024 •

edited by ivanpovazan

Loading

ivanpovazan commented Aug 1, 2024

jeffschwMSFT left a comment

dalexsoto left a comment

carlossanlop commented Aug 1, 2024

lewing commented Aug 1, 2024 •

edited

Loading

carlossanlop commented Aug 1, 2024 •

edited

Loading

carlossanlop commented Aug 1, 2024 •

edited

Loading

carlossanlop commented Aug 1, 2024

richaplinvs commented Aug 2, 2024

ivanpovazan commented Aug 5, 2024

ivanpovazan commented Aug 7, 2024

[release/9.0-preview7] Add swiftcall signature check for mono_class_try_get_swift_error_class #105813

[release/9.0-preview7] Add swiftcall signature check for mono_class_try_get_swift_error_class #105813

Conversation

github-actions bot commented Aug 1, 2024 • edited by ivanpovazan Loading

Customer Impact

Regression

Testing

Risk

ivanpovazan commented Aug 1, 2024

jeffschwMSFT left a comment

Choose a reason for hiding this comment

dalexsoto left a comment

Choose a reason for hiding this comment

carlossanlop commented Aug 1, 2024

lewing commented Aug 1, 2024 • edited Loading

carlossanlop commented Aug 1, 2024 • edited Loading

carlossanlop commented Aug 1, 2024 • edited Loading

carlossanlop commented Aug 1, 2024

richaplinvs commented Aug 2, 2024

ivanpovazan commented Aug 5, 2024

ivanpovazan commented Aug 7, 2024

[release/9.0-preview7] Add swiftcall signature check for `mono_class_try_get_swift_error_class` #105813

[release/9.0-preview7] Add swiftcall signature check for `mono_class_try_get_swift_error_class` #105813

github-actions bot commented Aug 1, 2024 •

edited by ivanpovazan

Loading

lewing commented Aug 1, 2024 •

edited

Loading

carlossanlop commented Aug 1, 2024 •

edited

Loading

carlossanlop commented Aug 1, 2024 •

edited

Loading