-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify MethodDesc::GetLoaderModule #106212
Simplify MethodDesc::GetLoaderModule #106212
Conversation
…tor` into O(1) operations - Today these are dependent on calling into `ClassLoader::ComputerLoaderModule`, which can be a very complex operation, and always requires walking all of the method's instantiation arguments. - This change makes puts a pointer to the Loader Module onto the `MethodDescChunk` and removes the need for running the potentially complex `ComputeLoaderModule` algorithm.
Tagging subscribers to this area: @mangod9 |
Should we do this for |
@lambdageek, yes, we should just add a field on |
@lambdageek Although, I'd like to make that change as part of a separate PR, as this one I think is good enough for the |
Sure, sounds good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Turn
MethodDesc::GetLoaderModule
andMethodDesc::GetLoaderAllocator
into O(1) operationsClassLoader::ComputerLoaderModule
, which can be a very complex operation, and always requires walking all of the method's instantiation arguments.MethodDescChunk
and removes the need for running the potentially complexComputeLoaderModule
algorithm.