Fix sbyte overflow in TypeName parsing #107261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
commented
Sep 2, 2024
| internal const sbyte ByRef = -3; | ||
| internal const int SZArray = -1; | ||
| internal const int Pointer = -2; | ||
| internal const int ByRef = -3; |
There was a problem hiding this comment.
this change was not necessary, but since the cast to sbyte was the source of the initial bug, I wanted to remove all usages of sbyte so we use int everywhere and don't ever run into similar problem
Merged
3 tasks
|
/ba-g the failure is unrelated |
3 tasks
adamsitnik
added a commit
to adamsitnik/runtime
that referenced
this pull request
Sep 9, 2024
4 tasks
carlossanlop
pushed a commit
that referenced
this pull request
Sep 12, 2024
* AssemblyNameInfo fuzzer (#107195) * add initial AssemblyNameInfo Fuzzer * fix the first bug that it has discovered * Fix sbyte overflow in TypeName parsing (#107261) * Add TypeNameFuzzer (#107206) Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> * [TypeName] Nested types should respect MaxNode count (#106334) * Improve AssemblyNameInfo Fuzzer (#107257) --------- Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com> Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovered by the Fuzzer in #107206 (comment)