-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] [mono] Fix crash in emit_llvmonly_handler_start #107590
Conversation
Do not try to emit branch when target_bb is not set
Tagging subscribers to this area: @lambdageek, @steveisok |
@lewing can we get the template filled in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can merge when ready
@lewing can you take a look at the PR failures? |
@lewing @radekdoulik today is the snap, please take a look at the PR failures |
/ba-g failures are known and tracked by BA it is only red because this is a release branch |
Backport of #107461 to release/9.0
/cc @lewing @radekdoulik
Customer Impact
Do not emit an llvm branch intruction when there is no target. This was never correct and in newer llvm versions it surfaces as a fatal error.
Regression
This existing error became fatal with new llvm versions.
Testing
Manual testing
Low, we avoid emitting incorrect code