-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mini] Don't use Unwind Backtrace on android-amd64 #107615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @lambdageek, @steveisok |
akoeplinger
approved these changes
Sep 10, 2024
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 10, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 10, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 11, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
This was referenced Sep 12, 2024
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 13, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 16, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 17, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 18, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 24, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
Match what we do for other android RIDs. The _Unwind_Backtrace support is only used when llvmonly mode is enabled, which is not something that we do for Android, AFAIK
lambdageek
force-pushed
the
android-no-unwind-amd64
branch
from
September 26, 2024 11:21
112537b
to
fd9f292
Compare
steveisok
approved these changes
Sep 26, 2024
This was referenced Sep 26, 2024
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11058147007 |
4 tasks
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
Match what we do for other android RIDs. The _Unwind_Backtrace support is only used when llvmonly mode is enabled, which is not something that we do for Android
grendello
added a commit
to dotnet/android
that referenced
this pull request
Sep 30, 2024
MonoVM requires `libunwind.a` on x86_64. Until the requirement is removed, we'll include the archive. dotnet/runtime#107615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match what we do for other android RIDs.
The _Unwind_Backtrace support is only used when llvmonly mode is enabled, which is not something that we do for Android, AFAIK