Address failures for Import_IterationCountLimitExceeded_ThrowsInAllottedTime #108028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2024
adamsitnik
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
LGTM, thank you for providing the fix and the explanation @vcsjones !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test works by making sure a particular API fails in a certain amount of time using RemoteExecutor. In a very busy CI environment, it may not fail fast enough.
We can address this two ways. First, we can extend the timeout to 10 seconds, up from 5. On a very fast computer, 100MM PBKDF2 rounds is still going to take more than 10 seconds (more like 20 to 30). So we can go a little higher while still looking for the "fast" failure we are looking for.
The second is to move the test to outerloop.
Fixes #105609