Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Change ICU WasmBuildTests to use wasmconsole and wasmbrowser templates #108271

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Sep 26, 2024

  • Change wbt icu methodology: we used to run them sending to helix, now our repo is in charge of running them with playwright (same as in WasmTemplateTests).
  • Some logic from WasmTemplateTests was useful to be reused with other tests, so it got moved to WasmTemplateTestsBase that will be a base class for all the other WBT that will be transformed to template-based.
  • Rename PredefinedIcudt to CustomIcuFile - it describes better what we're doing. This is not a public name.
  • Functionality of tests did not change.

issues discovered - to be addressed in a follow-up PR, this one is already big enough. They are all connected with transition from WasmAppBuilder to Wasm SDK:

Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@ilonatommy ilonatommy merged commit 01aa3d9 into dotnet:main Sep 27, 2024
22 of 24 checks passed
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
…ser` templates (dotnet#108271)

* Clean up icu tests (automatic mode).

* Block the failing test, mark problems with issue links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants