[Wasm] feat: Make boot json file configurable #108281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
jeromelaban
changed the title
maraf
reviewed
Sep 27, 2024
| @@ -19,6 +19,8 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <RunCommand Condition="'$(RunCommand)' == ''">dotnet</RunCommand> | |||
|
|
|||
| <WasmAppHostDir>$([MSBuild]::NormalizeDirectory($(MSBuildThisFileDirectory), '..', 'WasmAppHost'))</WasmAppHostDir> | |||
| <WasmBuildBootJsonFileName Condition="'$(WasmBuildBootJsonFileName)'==''">blazor.boot.json</WasmBuildBootJsonFileName> | |||
There was a problem hiding this comment.
I would prefer WasmBootConfigFileName property name
| @@ -19,6 +19,8 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <RunCommand Condition="'$(RunCommand)' == ''">dotnet</RunCommand> | |||
|
|
|||
| <WasmAppHostDir>$([MSBuild]::NormalizeDirectory($(MSBuildThisFileDirectory), '..', 'WasmAppHost'))</WasmAppHostDir> | |||
| <WasmBuildBootJsonFileName Condition="'$(WasmBuildBootJsonFileName)'==''">blazor.boot.json</WasmBuildBootJsonFileName> | |||
| <WasmBuildPublishBootJsonFileName Condition="'$(WasmBuildPublishBootJsonFileName)'==''">blazor.publish.boot.json</WasmBuildPublishBootJsonFileName> | |||
There was a problem hiding this comment.
Since this property is used only for intermediate file, we can compute the file name for publish based on WasmBootConfigFileName and skip the need property, or at least for "public property". Something like publish.$(WasmBootConfigFileName) should be enough
| @@ -589,8 +591,8 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <Target Name="_AddPublishWasmBootJsonToStaticWebAssets" DependsOnTargets="GeneratePublishWasmBootJson"> | |||
| <ItemGroup> | |||
| <_PublishWasmBootJson | |||
| Include="$(IntermediateOutputPath)blazor.publish.boot.json" | |||
| RelativePath="_framework/blazor.boot.json" /> | |||
| Include="$(IntermediateOutputPath)$(WasmBuildPublishBootJsonFileName)" | |||
There was a problem hiding this comment.
There are two other places where blazor.publish.boot.json is used
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
blazor.boot.jsonfile configurable from msbuild, usingWasmBuildBootJsonFileNameandWasmBuildPublishBootJsonFileName.