Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused locals in System.Runtime.WindowsRuntime #33035

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Remove unused locals in System.Runtime.WindowsRuntime #33035

merged 1 commit into from
Mar 2, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Mar 2, 2020

Contributes to #30457

I didn't find the definition of CoreDispatcher.RunAsync but it must return a task.

@stephentoub
Copy link
Member

I didn't find the definition of CoreDispatcher.RunAsync but it must return a task

it returns an IAsyncAction:
https://docs.microsoft.com/en-us/uwp/api/windows.ui.core.coredispatcher.runasync#Windows_UI_Core_CoreDispatcher_RunAsync_Windows_UI_Core_CoreDispatcherPriority_Windows_UI_Core_DispatchedHandler_

@jkotas
Copy link
Member

jkotas commented Mar 2, 2020 •
edited
Loading

Failure is ##32805. All failed legs are non-Windows and the change is Windows specific. Merging without rerunning.

@jkotas jkotas merged commit c822449 into dotnet:master Mar 2, 2020
@nxtn nxtn deleted the winrt branch March 2, 2020 05:47
@jaredpar jaredpar mentioned this pull request Mar 2, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nxtn @stephentoub @jkotas @Dotnet-GitSync-Bot