Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBOR] Implement indefinite length writer and reader support #33831

Merged
merged 12 commits into from
Mar 24, 2020
Merged

[CBOR] Implement indefinite length writer and reader support #33831

merged 12 commits into from
Mar 24, 2020

Commits on Mar 19, 2020

  1. Implement indefinite length writes

    @eiriktsarpalis
    eiriktsarpalis committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    1a77573 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. add indefinite-length cbor reader support

    @eiriktsarpalis
    eiriktsarpalis committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    c77f4ad View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Use CborReaderState.FormatError in Peek() instead of throwing excepti… 

    …ons.
    @eiriktsarpalis
    eiriktsarpalis committed Mar 23, 2020
    4 Configuration menu
    Copy the full SHA
    77717cc View commit details
    Browse the repository at this point in the history

  2. use verbose naming for indefinite-length write methods

    @eiriktsarpalis
    eiriktsarpalis committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    3e93149 View commit details
    Browse the repository at this point in the history

  3. address feedback

    @eiriktsarpalis
    eiriktsarpalis committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    993ab59 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. implement concatenation logic for indefinite-length string readers

    @eiriktsarpalis
    eiriktsarpalis committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    4cd3e44 View commit details
    Browse the repository at this point in the history

  2. add tests for nested indefinite-length strings

    @eiriktsarpalis
    eiriktsarpalis committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    baafb4c View commit details
    Browse the repository at this point in the history

  3. fix naming issues

    @eiriktsarpalis
    eiriktsarpalis committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    c6a83bb View commit details
    Browse the repository at this point in the history

  4. check that TryReadString() methods are idempotent on failed reads.

    @eiriktsarpalis
    eiriktsarpalis committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    dc30f79 View commit details
    Browse the repository at this point in the history

  5. use string.Create instead of char buffer; share single range list all… 

    …ocation
    @eiriktsarpalis
    eiriktsarpalis committed Mar 24, 2020
    2 Configuration menu
    Copy the full SHA
    19048da View commit details
    Browse the repository at this point in the history

  6. only clear List if it is guaranteed to be reused

    @eiriktsarpalis
    eiriktsarpalis committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    08f5538 View commit details
    Browse the repository at this point in the history

  7. move field to top of main CborReader source file.

    @eiriktsarpalis
    eiriktsarpalis committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    6912133 View commit details
    Browse the repository at this point in the history