Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore TargetArchitecture default #34295

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Restore TargetArchitecture default #34295

merged 2 commits into from
Mar 31, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 30, 2020

Fixes #34292

@jkotas
Copy link
Member Author

jkotas commented Mar 30, 2020

This is targeted minimal fix to address regression from my recent change. It would be nice to reconcile the different places where we compute the default, but that would be a more involved change.

@jkotas jkotas requested a review from sdmaclea March 30, 2020 20:35
@safern safern mentioned this pull request Mar 31, 2020
Merged
@jkotas jkotas merged commit d9b1a28 into dotnet:master Mar 31, 2020
@jkotas jkotas deleted the arch-default branch March 31, 2020 00:59
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipnavara filipnavara filipnavara approved these changes

@safern safern safern approved these changes

@sdmaclea sdmaclea sdmaclea approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux build --subsetCategory CoreCLR broken on x64 host
5 participants
@jkotas @filipnavara @safern @sdmaclea @Dotnet-GitSync-Bot