Address .NET 5-specific suggestions for System.Net.Http.Json #34355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalablecory
reviewed
Apr 1, 2020
|
|
||
| namespace System.Net.Http.Json | ||
| { | ||
| internal sealed partial class TranscodingReadStream : Stream |
There was a problem hiding this comment.
We shouldn't need a private implementation for .NET 5; you should contribute this as part of #30260
There was a problem hiding this comment.
@GrabYourPitchforks are you actively working on that issue, it is marked for 5.0, is that still the plan?
I want to assume that these TranscodingStreams aren't going to be the fix that closes above issue.
In that case, I think it makes more sense if I close this PR and wait for 30260 to close.
Comment on lines
+26
to
+44
| if (buffer == null) | ||
| { | ||
| throw new ArgumentNullException(nameof(buffer)); | ||
| } | ||
|
|
||
| if (offset < 0) | ||
| { | ||
| throw new ArgumentOutOfRangeException(nameof(offset)); | ||
| } | ||
|
|
||
| if (count < 0) | ||
| { | ||
| throw new ArgumentOutOfRangeException(nameof(count)); | ||
| } | ||
|
|
||
| if (buffer.Length - offset < count) | ||
| { | ||
| throw new ArgumentException(SR.Argument_InvalidOffLen); | ||
| } |
There was a problem hiding this comment.
The Memory ctor performs these checks; shouldn't need them here unless parameter names are different.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #33459
TranscodingRead/WriteStreamfor netcoreapp.TranscodingWriteStreamin order to prepare the road for the new sync HttpClient APIs (Sync API for HttpClient #32125).