Enable xunit1024 #34512
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1119,7 +1119,7 @@ public static void CompareOrdinal_NegativeLength_ThrowsArgumentOutOfRangeExcepti | |||||
| [InlineData("", "", true)] | ||||||
| [InlineData("", "hello", false)] | ||||||
| [InlineData("Hello", "", true)] | ||||||
| public static void Contains_String(string s, string value, bool expected) | ||||||
| { | ||||||
| Assert.Equal(expected, s.Contains(value)); | ||||||
| Assert.Equal(expected, s.AsSpan().Contains(value.AsSpan(), StringComparison.Ordinal)); | ||||||
|
|
@@ -1666,7 +1666,7 @@ public static void MakeSureNoSequenceEqualChecksGoOutOfRange_Char() | |||||
| [InlineData("Hello", "llo" + SoftHyphen, StringComparison.OrdinalIgnoreCase, false)] | ||||||
| [InlineData("", "", StringComparison.OrdinalIgnoreCase, true)] | ||||||
| [InlineData("", "a", StringComparison.OrdinalIgnoreCase, false)] | ||||||
| public static void EndsWith_ExplicitComparisonType(string s, string value, StringComparison comparisonType, bool expected) | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| { | ||||||
| if (comparisonType == StringComparison.CurrentCulture) | ||||||
| { | ||||||
|
|
@@ -2482,7 +2482,7 @@ public static void GetHashCode_EmbeddedNull_ReturnsDifferentHashCodes() | |||||
| [InlineData("", "", StringComparison.OrdinalIgnoreCase, true)] | ||||||
| [InlineData("123", 123, StringComparison.OrdinalIgnoreCase, false)] // Not a string | ||||||
| [InlineData("\0AAAAAAAAA", "\0BBBBBBBBBBBB", StringComparison.OrdinalIgnoreCase, false)] | ||||||
| public static void EqualsTest(string s1, object obj, StringComparison comparisonType, bool expected) | ||||||
| { | ||||||
| string s2 = obj as string; | ||||||
| if (s1 != null) | ||||||
|
|
@@ -4518,7 +4518,7 @@ public static void Remove_Invalid() | |||||
| "Mauris nulla sapien, convallis et quam quis, accumsan sodales mi. Praesent dapibus urna fermentum, sollicitudin posuere.", | ||||||
| 'e', 'E', | ||||||
| "LorEm ipsum dolor sit amEt, consEctEtur adipiscing Elit. Proin maximus convallis luctus. Curabitur porttitor mi blandit tEllus maximus varius. " + | ||||||
| "Mauris nulla sapiEn, convallis Et quam quis, accumsan sodalEs mi. PraEsEnt dapibus urna fErmEntum, sollicitudin posuErE.")] | ||||||
| public static void Replace_Char_Char(string s, char oldChar, char newChar, string expected) | ||||||
| { | ||||||
| Assert.Equal(expected, s.Replace(oldChar, newChar)); | ||||||
|
|
@@ -4639,7 +4639,7 @@ public void Replace_EmptyOldValue_ThrowsArgumentException() | |||||
| [InlineData("Hello", SoftHyphen + "Hel", StringComparison.OrdinalIgnoreCase, false)] | ||||||
| [InlineData("", "", StringComparison.OrdinalIgnoreCase, true)] | ||||||
| [InlineData("", "hello", StringComparison.OrdinalIgnoreCase, false)] | ||||||
| public static void StartsWith_WithExplicitComparisonType(string s, string value, StringComparison comparisonType, bool expected) | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| { | ||||||
| if (comparisonType == StringComparison.CurrentCulture) | ||||||
| { | ||||||
|
|
@@ -5125,7 +5125,7 @@ public static void SameSpanToLower() | |||||
| Assert.Equal(expected, s1.ToLower(CultureInfo.CurrentCulture).ToArray()); | ||||||
| Assert.Equal(expected, s1.ToLowerInvariant().ToArray()); | ||||||
| { | ||||||
| AssertExtensions.AssertThrows<InvalidOperationException, char>(a, a => | ||||||
| { | ||||||
| ReadOnlySpan<char> source = a; | ||||||
| Span<char> destination = a; | ||||||
|
|
@@ -5158,7 +5158,7 @@ public static void ToLowerOverlapping() | |||||
| var source = new ReadOnlySpan<char>(a, 1, 3); | ||||||
|
|
||||||
| AssertExtensions.AssertThrows<InvalidOperationException,char>(source, source => | ||||||
| { | ||||||
| var destination = new Span<char>(a, 3, 3); | ||||||
| source.ToLower(destination, CultureInfo.CurrentCulture); | ||||||
| }); | ||||||
|
|
@@ -5222,7 +5222,7 @@ public static void LengthMismatchToLower() | |||||
| } | ||||||
|
|
||||||
| [Fact] | ||||||
| public static void ToLower_2() | ||||||
|
There was a problem hiding this comment. What is the other ToLower test this is conflicting with? "ToLower_2" isn't descriptive about what makes this test different from a presumed "ToLower_1", so we should either pick descriptive names or combine the tests. There was a problem hiding this comment. It's this one, using There was a problem hiding this comment.
Sounds fine. Thanks. |
||||||
| { | ||||||
| var expectedSource = new char[3] { 'a', 'B', 'c' }; | ||||||
| var expectedDestination = new char[3] { 'a', 'b', 'c' }; | ||||||
|
|
@@ -5434,7 +5434,7 @@ public static void LengthMismatchToUpper() | |||||
| } | ||||||
|
|
||||||
| [Fact] | ||||||
| public static void ToUpper_2() | ||||||
|
|
||||||
| { | ||||||
| var expectedSource = new char[3] { 'a', 'B', 'c' }; | ||||||
| var expectedDestination = new char[3] { 'A', 'B', 'C' }; | ||||||
|
|
@@ -5544,7 +5544,7 @@ public static void Test_ToUpper_Culture(string actual, string expected, CultureI | |||||
| [Theory] | ||||||
| [InlineData("")] | ||||||
| [InlineData("hello")] | ||||||
| public static void ToStringTest(string s) | ||||||
| { | ||||||
| Assert.Same(s, s.ToString()); | ||||||
| Assert.Same(s, s.ToString(null)); | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to see this test's name left as-is, and the method it delegates to instead be renamed to something like CompressDecompress_RoundTrip_OuterLoop. Same goes for the other similar cases here. My reason is "BaseTests" doesn't really speak to what the test is doing, plus this is the test that runs 99% of the time, and the one it delegates to is relegated to only running when we run "OuterLoop".