Spanize interop in System.Net.NetworkInformation

[jkotas]

Faster and safer

[ghost]

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

[jkotas]

Depends on #35078

[wfurt]

LGTM

[Wraith2]

Which bits make it faster and which safer? It looks like it's adding unsafe modifiers (for the fixed) which makes is counter intuitive to be safer from a casual perspective.

[stephentoub]

Nice.

[stephentoub]

Which bits make it faster and which safer? It looks like it's adding unsafe modifiers (for the fixed) which makes is counter intuitive to be safer from a casual perspective.

The faster part is e.g. not using array marshaling and PtrToStructure, and using sizeof instead of Marshal.SizeOf.

The safer part is using span slicing instead of math on pointers, with the spans being bounds checked.

[jkotas]

unsafe modifiers (for the fixed) which makes is counter intuitive to be safe

unsafe modifier is required for unsafe C# language constructs, but not for unsafe APIs. It makes a poor indicator for whether the code is actually unsafe. #31354 should make it better.