Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated build scripts. #35115

Merged

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Apr 17, 2020

No Merge. Part of batched rollout in May: #35202

Remove the deprecated CoreCLR build scripts (build.cmd/build.sh and build.proj).

We're removing these scripts because I keep catching people making infra changes only in these scripts and then have to point them to the scripts we use in CI so their changes are actually effective.

@jkoritzinsky jkoritzinsky added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure-coreclr labels Apr 17, 2020
@jkoritzinsky jkoritzinsky added this to the 5.0 milestone Apr 17, 2020
@jkoritzinsky jkoritzinsky requested a review from a team April 17, 2020 17:30
@safern
Copy link
Member

safern commented Apr 17, 2020

Should we update any build defs that might be using these scripts?

@jkoritzinsky
Copy link
Member Author

There should be no build definitions using these scripts, but if there are, they should be updated.

I've validated that the CoreCLR build and formatting jobs don't use these scripts, and the optimization team and source-build team have moved off of these scripts to my knowledge.

Tagging @dseefeld and @brianrob so they can let us know if they haven't moved off these scripts yet and won't be able to do so by May 4th.

@safern
Copy link
Member

safern commented Apr 17, 2020

I asked cause I recalled seeing one, which just found, but I'm updating here: https://github.com/dotnet/runtime/pull/35011/files#diff-3672729464fb95f4293e8adfcbdbf3e6L11

@jkoritzinsky
Copy link
Member Author

Right.... I totally forgot about the networking stress tests since they use a completely separate pipeline. Yeah we need to update those. I can go do that if you want.

@jkoritzinsky
Copy link
Member Author

Actually, you're already fixing it, so that's covered then.

@brianrob
Copy link
Member

I have moved optimization training off of these scripts. Thanks for adding me here @jkoritzinsky.

@ViktorHofer ViktorHofer force-pushed the remove-deprecated-build-scripts branch from a53e0d6 to c822330 Compare May 4, 2020 12:55
@ViktorHofer ViktorHofer merged commit b114dee into dotnet:master May 4, 2020
@ViktorHofer ViktorHofer changed the title [NO_MERGE] Remove deprecated build scripts. Remove deprecated build scripts. May 6, 2020
@ViktorHofer ViktorHofer removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@jkoritzinsky jkoritzinsky deleted the remove-deprecated-build-scripts branch January 21, 2021 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants